Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade to TypeScript 5.x (and Lit 3.x?) #90

Closed
1 of 4 tasks
thescientist13 opened this issue Oct 21, 2023 · 0 comments · Fixed by #91
Closed
1 of 4 tasks

upgrade to TypeScript 5.x (and Lit 3.x?) #90

thescientist13 opened this issue Oct 21, 2023 · 0 comments · Fixed by #91
Labels
chore

Comments

@thescientist13
Copy link
Contributor

Type of Change

  • New Feature Request
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

Observed in #89 , compatibility, in particular around decorators was really broken, and so had to be downgraded back to 4.x as the new version of the Greenwood TypeScript plugin was upgraded to 5.x

Screenshot 2023-10-13 at 9 15 32 PM
Screenshot 2023-10-14 at 11 16 22 AM

Details

Some things worth trying / reviewing

  1. Review TypeScript recommendations for Lit v2
  2. Try upgrading to Lit v3
  3. Check out this Lit TS starter
  4. Would be good to upstream the working tsconfig.json to the plugin's README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

upgrade to latest version of typescript and lit AnalogStudiosRI/www.analogstudios.net
1 participant
@thescientist13