PerformanceDisplay styled by CSS instead of JS. #2779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ### 1.11 - 2015-07-01 | ||
|
|
||
| * Breaking changes | ||
| * PerformanceDisplay (private API) no longer takes style options. It is now styled with app-overridable CSS. Use `scene.debugShowFramesPerSecond` to enable it as before. |
There was a problem hiding this comment.
I would change this to something like "The performance statistics displayed by setting scene.debugShowFramesPerSecond to true can now be styled using the cesium-performanceDisplay CSS classes in shared.css.
|
@emackey everything else looks great! thanks! |
|
Thanks both. Ready. |
|
Great! thanks @emackey |
hpinkos
pushed a commit
that referenced
this pull request
Jun 3, 2015
PerformanceDisplay styled by CSS instead of JS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved some JS to CSS. You can turn this display on from the URL bar with
?stats=true.