Fog dark

[lilleyse]

I experienced an issue with the fog when testing the 3d Models Sandcastle. This happens when I first orient the camera into the ground (horizon view), and then start zooming out.

[pjcozzi]

@bagnell can you look at this before the 1.16 release? I suspect this is because of the time of day and the view direction, the blend color is dusk/dawn, but it's strange that it changes when zoomed out.

[pjcozzi]

@bagnell just a reminder that 1.16 is coming up next week. No one has reported running into this yet so we can push if it is really hard to fix.

[bagnell]

Its either a problem with the atmosphere code or the camera collision with the terrain but I haven't tracked it down. This happens in master too. If you go to the same Sandcastle example in master, keep rotating down and the sky will become super bright.

[lilleyse]

In Camera changing

Matrix4.inverse(camera._viewMatrix, camera._invViewMatrix);

to inverseTransformation fixes both fog and shadows. It looks like the camera vectors are a bit wrong, I'll look into this more but at least here is the easy fix.

[lilleyse]

Whoops other way around, inverseTransformation to inverse fixes it.

[pjcozzi]

There was a proposed workaround in #3750.