Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels disappearing #3730

Closed
TomPed opened this issue Mar 21, 2016 · 8 comments
Closed

Labels disappearing #3730

TomPed opened this issue Mar 21, 2016 · 8 comments

Comments

@TomPed
Copy link
Contributor

TomPed commented Mar 21, 2016

This was found during AnalyticalGraphicsInc/cesium-website#982. Here is a .gif of the issue:
label
And here is the code for this example.

Basically what is happening is when you left click, we are picking the Milk Truck and getting the position from pickPosition. Then we are getting the altitude component of the position and adding it as a label. The altitude is also getting logged to the console. If you try click on the roof of the truck (1190m altitude) the label gets added fine. This is also true if you click on the hood of the truck (1188m-1189m altitude). But the second you go to add both of the labels, the labels get messed up.

@hpinkos
Copy link
Contributor

hpinkos commented Mar 21, 2016

This might be Mac specific. I can't reproduce it on my machine.

@TomPed
Copy link
Contributor Author

TomPed commented Mar 21, 2016

In that case I'm running:

OS: OS X El Capitan, Version: 10.11.3 (15D21)

Browser: Chrome, Version 49.0.2623.87 (64-bit)

@pjcozzi
Copy link
Contributor

pjcozzi commented Mar 21, 2016

I can reproduce this on Windows. As I discussed with @TomPed offline, I suspect this happens when the texture atlas is updated or recreated.

To reproduce this, click the top of the milk truck, then start click lower spots until you click the bottom of the wheel:

ok

@pjcozzi
Copy link
Contributor

pjcozzi commented Mar 21, 2016

@bagnell can you add this to your list? @lilleyse and I also ran into this with picking in 3D Tiles. If it's not a quick fix, then we can evaluate.

@pjcozzi
Copy link
Contributor

pjcozzi commented Mar 21, 2016

I think there is also a multifrustum bounding sphere issue here:
ok

@e-andersson
Copy link
Contributor

I have been running into a similar issue with labels and 3D Tiles, might be what @pjcozzi mentioned above.

When picking a position (on a 3D Tile) and then placing a label there, a partial label will appear, with some glyphs missing. Should I file a separate issue for this?

Can be reproduced in the Cesium Sandcastle:

  1. Open the 3D Tiles showcase
  2. Append below code snippet to the existing code
  3. Click somewhere
var labels = scene.primitives.add(new Cesium.LabelCollection());

function addLabel(position, name) {
    labels.add({
      position: position,
      text: name
    });
}

document.addEventListener('click', function(event) {
    var windowPosition = new Cesium.Cartesian2(event.clientX, event.clientY);
    var worldPosition = scene.pickPosition(windowPosition);
    addLabel(worldPosition, 'Hello glyphless world');
});

@pjcozzi
Copy link
Contributor

pjcozzi commented Apr 4, 2016

@e-andersson I suspect it is the same issue so let's keep it is here unless we determine otherwise.

3D Tiles Sandcastle demo link

@bagnell
Copy link
Contributor

bagnell commented Aug 26, 2016

This was fixed in #3823.

@bagnell bagnell closed this as completed Aug 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants