Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected error message in cesium 1.26 anfter adding cylinder entity #4428

Closed
bmckilligan opened this issue Oct 13, 2016 · 7 comments
Closed

Comments

@bmckilligan
Copy link

This is occurring after adding an entity with a cylinder geometry.

this was introduced in cesium 1.26

I have tested it with version 1.23, 1.24, 1.25 without issue.

I am trying to recreate the error in a Sandcastle example, but have been unsuccessful so far

Cesium.js:175233 An error occurred while rendering. Rendering has stopped.
undefined
TypeError: Cannot read property 'longitude' of undefined
TypeError: Cannot read property 'longitude' of undefined
at GeographicProjection.project (http://localhost/cds/Scripts/_Libs/cesium/1.26/Cesium.js:5684:29)
at updateBatchTableBoundingSpheres (http://localhost/cds/Scripts/_Libs/cesium/1.26/Cesium.js:93503:39)
at Primitive.update (http://localhost/cds/Scripts/_Libs/cesium/1.26/Cesium.js:93890:13)
at PrimitiveCollection.update (http://localhost/cds/Scripts/_Libs/cesium/1.26/Cesium.js:157993:27)
at updatePrimitives (http://localhost/cds/Scripts/_Libs/cesium/1.26/Cesium.js:166212:27)
at executeCommandsInViewport (http://localhost/cds/Scripts/_Libs/cesium/1.26/Cesium.js:166122:9)
at updateAndExecuteCommands (http://localhost/cds/Scripts/_Libs/cesium/1.26/Cesium.js:165990:17)
at render (http://localhost/cds/Scripts/_Libs/cesium/1.26/Cesium.js:166420:9)
at Scene.render (http://localhost/cds/Scripts/_Libs/cesium/1.26/Cesium.js:166458:13)
at CesiumWidget.render (http://localhost/cds/Scripts/_Libs/cesium/1.26/Cesium.js:175280:25)

@mramato
Copy link
Contributor

mramato commented Oct 14, 2016

If it crashes in your app but not in Sandcastle then the cylinder may not be the real problem. Have you tried running your app in incognito mode? Does it happen in all browsers? Unfortunately there's not much we can do without a reproducible test case.

@bmckilligan
Copy link
Author

totally understandable, for the moment I rolled back to 1.25 until I can isolate the problem,

cesium stops rendering and displays the message until I run code to remove the entity , after this it snaps back to life

@bmckilligan
Copy link
Author

I have isolated the bug,

it occurs when the viewer is initiated with scene3DOnly: true

http://cesiumjs.org/Cesium/Apps/Sandcastle/?src=Hello%20World.html&label=Showcases&gist=de5672557b9ff6ee9f5bfa9a3564e49b

@hpinkos
Copy link
Contributor

hpinkos commented Oct 18, 2016

Thanks for looking into this @bmckilligan! I've labeled this for the bug bash, hopefully it's an easy fix and we can get it resolved soon

mramato added a commit that referenced this issue Oct 19, 2016
updateBatchTableBoundingSpheres was using the BoundingSphere center without
applying the modelMatrix to the sphere first.


Fixes #4431 and #4428
@hpinkos
Copy link
Contributor

hpinkos commented Oct 21, 2016

related? #3523

@mramato
Copy link
Contributor

mramato commented Oct 21, 2016

Yes, #4461 should fix #3523 as well. I just tried it and it works as expected on my branch. Can you please confirm?

@pjcozzi
Copy link
Contributor

pjcozzi commented Oct 21, 2016

@bmckilligan thanks again for the report. This was fixed in #4461 and will be in Cesium 1.27 on Nov 1.

@mramato @hpinkos will test #3523 now.

@pjcozzi pjcozzi closed this as completed Oct 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants