Outline geometry #1021
Outline geometry #1021
Conversation
| var extrudedOutlineExtent = new Cesium.GeometryInstance({ | ||
| geometry : new Cesium.ExtentOutlineGeometry({ | ||
| extent : extent, | ||
|
|
|
There are some artifacts with the ellipsoid outline: I assume this is because we are using cube-map tessellation for the fill as we discussed and/or there are multi-frustum issues. As we discussed, we can change the fill tessellation if need be. Let me know what you decide. |
| var indices; | ||
| var positions; | ||
|
|
||
| // Positions only - no need to duplicate corner points |
There was a problem hiding this comment.
This comment doesn't make sense for the outline. Remove it.
| var eastVecScratch = new Cartesian3(); | ||
| var northVecScratch = new Cartesian3(); | ||
|
|
||
| function pointOnEllipsoid(theta, rotation, northVec, eastVec, aSqr, ab, bSqr, mag, unitPos, result) { |
There was a problem hiding this comment.
Is this and other functions below duplicate with EllipseGeometry? If so, put them in a common file as @private functions (no need to explicitly unit test or doc them) so both geometries can use them.
Same comment if other geometries have a similar situation.
|
Tests pass. JSHint is good. The Sandcastle example is good. I am OK with the design of separate geometries for outlines, but I think there is a lot of duplication with the implementation details that we can improve. @bagnell you can finish the review and merge. Also update the draft tutorial. |
|
There's an artifact with polygons. A line on the extruded wall pops in and out. |
|
@bagnell I saw this too, but I suspect it is depth-test related, not geometric. Could be wrong, I suppose. |
|
@pjcozzi I think you're right. It looks like there's some z fighting on the ellipsoids too. |
|
Yes, we already mentioned that - see above. |
Conflicts: CHANGES.md Source/Core/ExtentGeometry.js Source/Core/PolygonGeometry.js Source/Core/PolylinePipeline.js Source/Core/WallGeometry.js
Yes |
|
@hpinkos Can you merge in master? |
| position.z = rSurfaceZ + nZ * maxHeight; | ||
| } | ||
|
|
||
| if ( minHeight !== 'undefined') { |
Conflicts: CHANGES.md
Added the following
Geometrytypes:BoxOutlineGeometryCircleOutlineGeometryCylinderOutlineGeometryEllipseOutlineGeometryEllipsoidOutlineGeometryExtentOutlineGeometryPolygonOutlineGeometrySphereOutlineGeometryWallOutlineGeometryI updated the sandcastle Geometry and Appearances example to include examples of these geometries.
I also changed the extrusion parameters for
ExtentGeometryto make it consistent with the extrusion parameters for polygon and ellipse.