Don't assume the first element of the KML node is the root feature #2945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NetworkLinkControl elements can be children of the kml root node but do not count as the root feature node. Instead, we need to iterate all kml child nodes to locate the root feature node.
|
Looks good. |
pjcozzi
added a commit
that referenced
this pull request
Aug 18, 2015
…hildren Don't assume the first element of the KML node is the root feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NetworkLinkControl elements can be children of the kml root node but do not count as the root feature node. Instead, we need to iterate all kml child nodes to locate the root feature node.
Reported via the forum.
Below test fails in master, passes in this branch.