Be more lenient when processing KML coordinates #3124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our code in master is pretty strict whenprocessing KML, but it turns out Google will let you pass almost anything and just use zeros (in the case of single coordinates) or create an object without an geometry (in the case of linear rings). This change makes Cesium match that behavior, event though the spec itself says it's invalid. I also noticed the Viewer specs had a bug because Viewer itself was listed in the list of requires (the way our specs work, the thing being tested has to be in the list of requires and has to be first). In this case, because all creation is deferred to the `createViewer` helper, it wasn't being included. To test this just run/review the unit tests, they are updated to reflect the change in functionality.
|
Looks good. |
|
Update CHANGES.md in master. |
pjcozzi
added a commit
that referenced
this pull request
Oct 23, 2015
Be more lenient when processing KML coordinates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our code in master is pretty strict when processing KML, but it turns out Google will let you pass almost anything and just use zeros (in the case of single coordinates) or create an object without an geometry (in the case of linear rings). This change makes Cesium match that behavior, event though the spec itself says it's invalid.
I also noticed the Viewer specs had a bug because Viewer itself was listed in the list of requires (the way our specs work, the thing being tested has to be in the list of requires and has to be first). In this case, because all creation is deferred to the
createViewerhelper, it wasn't being included.To test this just run/review the unit tests, they are updated to reflect the change in functionality.