Polyline entity updates with correct ellipsoid #3174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @hpinkos, I updated CHANGES since this was a user-reported issue. |
mramato
added a commit
that referenced
this pull request
Nov 9, 2015
…ipsoid Polyline entity updates with correct ellipsoid
| positions : undefined, | ||
| granularity : undefined, | ||
| height : undefined | ||
| generateCartesianArcOptions.ellipsoid = geometryUpdater._scene.globe.ellipsoid; |
There was a problem hiding this comment.
scene.globe is not guaranteed to exist, generally we prefer scene.mapProjection.ellipsoid for this kind of thing.
There was a problem hiding this comment.
@emackey, can you submit a separate issue for this. A quick search for scene.globe. shows that there are quite a few places we are access a property on globe without checking. For the specific case of scene.globe.ellipsoid, we should probably add an ES5 getter for scene.ellipsoid so that this mistake is harder to make.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported on the forum: https://groups.google.com/forum/?hl=en#!topic/cesium-dev/Zkt3n4_4lI8
The ellipsoid wasn't being sent to
PolylinePipeline.generateCartesianArcin the polyline'sDynamicGeometryUpdaterso it was using WGS84 instead.