CZML model node transformations #3316

shunter · 2015-12-08T22:45:41Z

This builds on top of Greg's changes in #3003 and includes all of them.

I'm opening this for initial review, though I still need to add some additional tests.

czml-writer pr: AnalyticalGraphicsInc/czml-writer#102

This adds support for time-varying model node transformations in CZML. A NodeTransformation aggregates scale, translation and rotation as values. NodeTransformationProperty produces NodeTransformation values from properties.

ModelGraphics now has nodeTransformations which is a new PropertyBag object, which is a key-value store for properties, including definitionChanged propagation. PropertyBag may be useful for eventually supporting custom CZML properties.

…gular property so that it adheres to any interval specified in the model packet.

…ditional transformations from czml

…to specify if glTF animations should be started

…imations

Rename to `NodeTransformation` to match CZML. Create new `PropertyBag` class that allows for notification of changes of properties added with `addProperty`.

…ormations

shunter · 2015-12-08T22:49:45Z

With Greg's help, I put together an Sandcastle example that shows this working.

var viewer = new Cesium.Viewer('cesiumContainer');

viewer.dataSources.add(Cesium.CzmlDataSource.load('https://gist.githubusercontent.com/shunter/08c95fcebb1c3506530a/raw/09805419206c60eea4cf8948c056a92ae29b15c8/satellite.czml')).then(function(dataSource) {
    viewer.trackedEntity = dataSource.entities.getById('Satellite/Satellite2');
});

pjcozzi · 2015-12-08T23:28:24Z

It would be nice to include a CZML example for this in Sandcastle like the other CZML examples.

Also, I was not planning on reviewing this unless there is something in particular you guys want me to look at.

Also, do you guys want to write a short tech blog post on CZML/glTF interop? There would be interest from the Cesium and glTF communities.

shunter · 2015-12-09T19:22:44Z

For the sandcastle example, I figure we probably don't want to commit the 4MB gltf file from STK referenced in my previous example above. Let me know if you think this is too dumb looking for a demo. I wanted to make the transformations visually obvious.

http://shunter.github.io/nodeTransformations/Apps/Sandcastle/gallery/CZML%20Model%20-%20Node%20Transformations.html

pjcozzi · 2015-12-09T22:16:08Z

I don't think users will realize that the example is correct. Perhaps just spin the Cesium Milk truck 360 degrees - or if you really want to emphasize the "we're referencing a node id, not the entire model aspect", @lilleyse could create a simple model with two nodes for this.

shunter · 2015-12-09T22:43:57Z

Yeah, I think we need to emphasize that it affects nodes, and not the whole model (spinning a whole model is trivial without any of these changes). I'm happy to use a different model instead.

pjcozzi · 2015-12-09T22:55:39Z

@lilleyse can you create something simple for @shunter?

lilleyse · 2015-12-10T01:45:24Z

What about raising and lowering the body of the milk truck, like if someone was changing the suspension? Or maybe rotating the wheels of the truck to look like a turn?

mramato · 2015-12-10T21:56:41Z

Source/DataSources/NodeTransformation.js

+     * @param {Cartesian3} [translation=Cartesian3.ZERO] A {@link Cartesian3} specifying the (x, y, z) translation to apply to the node.
+     * @param {Quaternion.IDENTITY} [rotation=Quaternion.IDENTITY] A {@link Quaternion} specifying the (x, y, z, w) rotation to apply to the node.
+     */
+    var NodeTransformation = function(scale, translation, rotation) {


I understand why this is in DataSources, but it certainly looks like something I would except to be in Core. Are we sure that we're never going to need something like this at the lower level?

Core is probably a better choice. Probably name it Transform, AffineTransform, or TranslationRotationScale.

Throughout, the parameters should also be in that order: translation, rotation, scale. TRS, as it is called, is common in graphics and what we say in glTF.

OK, renamed to TranslationRotationScale and moved to Core.

…e. Make PropertyBag take a result parameter in its getValue function.

shunter · 2015-12-11T21:37:26Z

regarding node transformations, I put together a sandcastle demo that allows direct manipulation of node transforms in the UI.

http://shunter.github.io/modelNodes/3D%20Model%20Node%20Explorer.html

you can make Cesium Man do a little dance for you by rotating joints.

I'm thinking this could be useful to go into the development directory. opinions?

pjcozzi · 2015-12-12T15:02:22Z

The development directory is OK, but most developers using models would be interested in this so I would suggest putting it in the main Sandcastle examples.

pjcozzi · 2015-12-12T15:02:42Z

There will also be a separate CZML example, right?

shunter · 2015-12-15T16:34:48Z

I left the Model Node Explorer example in the development section because 1) it does not use the entity API and 2) it uses private Cesium members (it's not possible to enumerate model nodes in the public API).

I also added the CZML example. Cesium Man says hello: http://shunter.github.io/nodeTransformations/CZML%20Model%20-%20Node%20Transformations.html

pjcozzi · 2015-12-15T16:37:10Z

Amazing.

mramato · 2015-12-15T16:45:46Z

Also, as soon as this is merged and @gbeatty's exporter is updated, we are going to replace the C4ISR example from the website with an awesome model-based simulation. I also want to look into making a separate space-based example, perhaps with the IIS or maneuvering satellites.

mramato · 2015-12-18T20:09:00Z

We totally need a demo of the Cesium man doing the robot ;)

mramato · 2015-12-18T20:10:46Z

Source/Core/TranslationRotationScale.js

+    var defaultRotation = Quaternion.IDENTITY;
+
+    /**
+     * A set of transformations to apply to a particular node in a {@link Model}.


This is kind of more generic now, right? @pjcozzi do you have a suggestion for a one-line definition of TRS?

An affine transformation defined by a translation, rotation, and scale.

Add `Matrix4.fromTranslationRotationScale`. Remove `TranslationRotationScale.prototype.toMatrix` Tweak documentation Get rid of empty function Update tests.

…ormations

mramato · 2015-12-18T21:12:19Z

My changes are in and I also updated CHANGES with the full list (it's actually quite a bit).

Awesome work @gbeatty and @shunter. This is an often requested chunk of functionality and will make a lot of people very happy.

…sformations CZML model node transformations

gbeatty and others added 16 commits June 18, 2015 15:59

initial implementation of model transformations in czml

c3903fc

Fixed ModelVisualizer and tests

7a65133

initial working czml implementation for model transformations

818529e

changed ModelGraphics nodeTransformations from a raw property to a re…

895c914

…gular property so that it adheres to any interval specified in the model packet.

remove automatic model animation when a model is loaded via czml

9b48563

include the model node's default transformation matrix when adding ad…

4462be8

…ditional transformations from czml

Update CZML node transformation names

f005d20

code formatting cleanup

06ad0e8

Added a runAnimations property to ModelGraphics.js to allow the user …

9359a01

…to specify if glTF animations should be started

Merge branch 'master' into czmlModelAnimations

22f6ef3

Merge remote-tracking branch 'origin/master' into gbeatty-czmlModelAn…

f2e0d0e

…imations

Further work on node transformations.

8e4f397

Rename to `NodeTransformation` to match CZML. Create new `PropertyBag` class that allows for notification of changes of properties added with `addProperty`.

Merge remote-tracking branch 'origin/master' into czmlModelNodeTransf…

46b8234

…ormations

cleanup

7a321e1

cleanup

7755e22

load runAnimations from CZML.

8d38198

shunter mentioned this pull request Dec 8, 2015

Updates to CZML for model node animations #3003

Closed

Add tests for PropertyBag.

4a3b0b7

mramato reviewed Dec 10, 2015
View reviewed changes

shunter added 3 commits December 11, 2015 10:55

Rename NodeTransformation to TranslationRotationScale and move to Cor…

781952f

…e. Make PropertyBag take a result parameter in its getValue function.

clean up module paths.

a90ddbc

originalNodeMatrixHash needs to be per-model

8ea6732

Add sandcastle examples

21ee2ae

mramato reviewed Dec 18, 2015
View reviewed changes

mramato added 3 commits December 18, 2015 15:53

Updates after review

5bbf684

Add `Matrix4.fromTranslationRotationScale`. Remove `TranslationRotationScale.prototype.toMatrix` Tweak documentation Get rid of empty function Update tests.

Merge remote-tracking branch 'origin/master' into czmlModelNodeTransf…

ac342c1

…ormations

Update CHANGES.

3147d89

mramato added a commit that referenced this pull request Dec 18, 2015

Merge pull request #3316 from AnalyticalGraphicsInc/czmlModelNodeTran…

403b01f

…sformations CZML model node transformations

mramato merged commit 403b01f into master Dec 18, 2015

mramato deleted the czmlModelNodeTransformations branch December 18, 2015 21:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CZML model node transformations #3316

CZML model node transformations #3316

shunter commented Dec 8, 2015

shunter commented Dec 8, 2015

pjcozzi commented Dec 8, 2015

shunter commented Dec 9, 2015

pjcozzi commented Dec 9, 2015

shunter commented Dec 9, 2015

pjcozzi commented Dec 9, 2015

lilleyse commented Dec 10, 2015

mramato Dec 10, 2015

pjcozzi Dec 10, 2015

shunter Dec 11, 2015

shunter commented Dec 11, 2015

pjcozzi commented Dec 12, 2015

pjcozzi commented Dec 12, 2015

shunter commented Dec 15, 2015

pjcozzi commented Dec 15, 2015

mramato commented Dec 15, 2015

mramato commented Dec 18, 2015

mramato Dec 18, 2015

pjcozzi Dec 18, 2015

mramato Dec 18, 2015

mramato commented Dec 18, 2015

CZML model node transformations #3316

CZML model node transformations #3316

Conversation

shunter commented Dec 8, 2015

shunter commented Dec 8, 2015

pjcozzi commented Dec 8, 2015

shunter commented Dec 9, 2015

pjcozzi commented Dec 9, 2015

shunter commented Dec 9, 2015

pjcozzi commented Dec 9, 2015

lilleyse commented Dec 10, 2015

mramato Dec 10, 2015

Choose a reason for hiding this comment

pjcozzi Dec 10, 2015

Choose a reason for hiding this comment

shunter Dec 11, 2015

Choose a reason for hiding this comment

shunter commented Dec 11, 2015

pjcozzi commented Dec 12, 2015

pjcozzi commented Dec 12, 2015

shunter commented Dec 15, 2015

pjcozzi commented Dec 15, 2015

mramato commented Dec 15, 2015

mramato commented Dec 18, 2015

mramato Dec 18, 2015

Choose a reason for hiding this comment

pjcozzi Dec 18, 2015

Choose a reason for hiding this comment

mramato Dec 18, 2015

Choose a reason for hiding this comment

mramato commented Dec 18, 2015