Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added zoom algorithm that better maintains target point in 3D #4016

Merged
merged 7 commits into from
Jun 28, 2016

Conversation

e-andersson
Copy link
Contributor

Submitting PR against master instead of 3d-tiles as per request from @bagnell in #3924.

@pjcozzi
Copy link
Contributor

pjcozzi commented Jun 10, 2016

Thanks again, @e-andersson! Can you please update CHANGES.md? This will be released in Cesium 1.23 on July 1.

The test coverage isn't great because there are code paths that only run when terrain is picked.

@bagnell can we programmatically pick terrain? Or extract or mock something to test this block?

@e-andersson
Copy link
Contributor Author

@pjcozzi CHANGES.md updated now!

@pjcozzi
Copy link
Contributor

pjcozzi commented Jun 13, 2016

@e-andersson can you also merge in master? There is probably a minor conflict in CHANGES.md.

@pjcozzi
Copy link
Contributor

pjcozzi commented Jun 13, 2016

@bagnell is anything else needed here?

@bagnell can we programmatically pick terrain? Or extract or mock something to test this block?

@e-andersson
Copy link
Contributor Author

@pjcozzi Ah, I intended to but forgot it.

@pjcozzi
Copy link
Contributor

pjcozzi commented Jun 23, 2016

@e-andersson can you please merge in master? Sorry, there is another conflict.

@bagnell is this ready to merge? Is it possible to better test this? I would like to get this into 1.23.

@e-andersson
Copy link
Contributor Author

Will have a look at it this evening.
On 23 Jun 2016 1:21 p.m., "Patrick Cozzi" notifications@github.com wrote:

@e-andersson https://github.com/e-andersson can you please merge in
master? Sorry, there is another conflict.

@bagnell https://github.com/bagnell is this ready to merge? Is it
possible to better test this? I would like to get this into 1.23.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#4016 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/API5l2eEn_-RjffS-9m4qkLv10t_yGQhks5qOmw3gaJpZM4IyvFx
.

@bagnell
Copy link
Contributor

bagnell commented Jun 27, 2016

@pjcozzi This is ready to merge. I'm not sure of a good way to test where the terrain is picked. We should create an issue to add tests everywhere Camera and ScreenSpaceCameraController picks terrain.

@e-andersson
Copy link
Contributor Author

@pjcozzi merged in master, sorry I couldn't do it sooner.

@pjcozzi pjcozzi merged commit 3a7bc58 into CesiumGS:master Jun 28, 2016
@pjcozzi
Copy link
Contributor

pjcozzi commented Jun 28, 2016

New functionality looks great, thanks again @e-andersson!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants