-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix morphing from 2D to 3D #4388
Conversation
Update CHANGES.md. Does this need unit tests? I'm not sure how well the original code was covered. |
There are no tests for |
From #4383:
The final morph from 2D to 3D freezes for me. |
@pjcozzi This is ready for another look. I fixed the freeze by not updating imagery or terrain during the morph, but there might be a deeper problem. The freeze was caused by the loops here: https://github.com/AnalyticalGraphicsInc/cesium/blob/master/Source/Scene/ImageryLayer.js#L539 |
Looks good.
Submit an issue if there is a real problem. |
Fixes #4383.
Not just when tracking models. It also happens for any of the geometry Sandcastle examples. For example, double click one of the boxes in the box example to track it. When morphing to 3D from 2D, the camera position will remain the same when switching from an orthographic projection to a perspective projection. It was much more noticeable in the model example. This change adds back the flight to the home view.