Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kdbush to be a require module. #4467

Merged
merged 4 commits into from
Oct 25, 2016
Merged

Update kdbush to be a require module. #4467

merged 4 commits into from
Oct 25, 2016

Conversation

bagnell
Copy link
Contributor

@bagnell bagnell commented Oct 20, 2016

Fixes #4418.

@pjcozzi
Copy link
Contributor

pjcozzi commented Oct 20, 2016

Update CHANGES.md.

@chris-cooper could you please verify this?

@mramato
Copy link
Contributor

mramato commented Oct 20, 2016

I honestly think the warning @chris-cooper reported is a false positive. It's not really a pre-built javascript file, it just has the UMD boilerplate at the top so that it can be used in multiple different module loaders.

The main (and only) problem I have with this manual clean up that @bagnell did is that it means we have to do it every time we want to update to a new version of kdbush.

If we really want to "fix" this, we should be automatically grabbing the version from npm and doing whatever we need automatically during npm install. Of course this is a longer-term change I'd like to see where we use npm for front-end dependcies as well (for non-built versions).

Whatever you guys decide for now is fine with me, but we need to strive to be able to effortless update third party libraries on a regular basis.

@pjcozzi
Copy link
Contributor

pjcozzi commented Oct 21, 2016

@mramato is right in general.

For now for this case, this change is fine since kdbush is pretty stable and has not had significant updates recently: https://github.com/mourner/kdbush/commits/master

@chris-cooper please merge once you confirm, thanks.

@pjcozzi
Copy link
Contributor

pjcozzi commented Oct 21, 2016

@bagnell update CHANGES.md.

@chris-cooper
Copy link
Contributor

Yes this makes the warning go away. I'm happy for it to be merged once @bagnell has updated CHANGES.md.

@bagnell
Copy link
Contributor Author

bagnell commented Oct 25, 2016

@pjcozzi @chris-cooper CHANGES.md has been updated. This is ready.

@pjcozzi
Copy link
Contributor

pjcozzi commented Oct 25, 2016

Thanks @bagnell @chris-cooper

@pjcozzi pjcozzi merged commit 047e54f into master Oct 25, 2016
@pjcozzi pjcozzi deleted the kdbush branch October 25, 2016 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants