Model coloring #4547

lilleyse · 2016-10-29T01:31:14Z

I was inspired by this post on the forum to be able to color a model with a solid color.

The blend color is mixed with the rendered colored. It's not possible to just replace the diffuse color unless some semantic is defined, but this is probably not worth the trouble.

Is this something we want to support in the Entity API as well?

pjcozzi · 2016-10-30T15:13:48Z

Somewhat related to #2387 and #4314.

pjcozzi · 2016-10-30T15:17:18Z

Source/Scene/Model.js

+         *
+         * @default Color.RED
+         */
+        this.blendColor = defaultValue(options.blendColor, Color.RED);


Is the intention to allow RGBA values? If so, the render state may need to change on the fly when alpha changes from one to non-one. Likewise, you may want to optimize the case when alpha is zero and not issue the DrawCommand.

If the intention is only RGB, the explicitly document that and throw when alpha is non-zero.

I would support alpha so users can fade in/out a model with this.

I had intentionally left alpha out, but I do think it will be nice to support in this PR.

pjcozzi · 2016-10-30T15:19:36Z

Source/Scene/Model.js

+    function modifyShaderForBlendColor(shader) {
+        shader = ShaderSource.replaceMain(shader, 'czm_blend_main');
+        shader +=
+            'uniform vec4 czm_blendColor; \n' +


Instead of czm_, should we use something like gltf_ (like we use tile_ in 3D Tiles)? I probably used czm_ elsewhere for 3D models, but perhaps we should reserve it for built-ins.

pjcozzi · 2016-10-30T15:20:16Z

Add this to the Sandcastle example.

And yes, I expect we would want Entity API support and eventually CZML.

lilleyse · 2016-12-05T21:56:55Z

Ready for review.

Added Entity API and CZML support. Also added alpha support.

lilleyse · 2016-12-05T22:01:11Z

There are still some unavoidable artifacts when OIT is off due to lack of triangle sorting. The back/front commands help though, but can't prevent multiple front faces from being drawn in arbitrary order.

This is with alpha of 0.9 to highlight the issue.

lilleyse · 2016-12-05T22:04:58Z

Another note: glTF that are marked as premultiplied are now un-premultiplied. Besides making it easier to blend colors in this PR, it will also improve OIT which overrides the glTF's render state and always does un-premultiplied alpha blending.

pjcozzi · 2016-12-05T22:10:41Z

The back/front commands help though, but can't prevent multiple front faces from being drawn in arbitrary order.

Ah yes, this will only work for convex objects. Perhaps it is not worth it since this is a fallback and only a partial solution that is unlikely to be enough in common cases.

lilleyse · 2016-12-05T22:13:13Z

Ah yes, this will only work for convex objects. Perhaps it is not worth it since this is a fallback and only a partial solution that is unlikely to be enough in common cases.

Ok, then it may be worth changing 3d-tiles as well which also generates translucent front/back commands.

pjcozzi · 2016-12-05T22:14:29Z

Is Blend Alpha supposed to work when Blend Amount is zero? Blend Color does not.

pjcozzi · 2016-12-05T22:16:19Z

In the Sandcastle example, Blend Color going from 0 to 1 is awkward. If a color picker is trivial, let's use it; otherwise, anything else like a dropdown would be fine.

pjcozzi · 2016-12-05T22:16:58Z

Ok, then it may be worth changing 3d-tiles as well which also generates translucent front/back commands.

OK with me, probably my doing.

lilleyse · 2016-12-05T22:21:31Z

Is Blend Alpha supposed to work when Blend Amount is zero? Blend Color does not.

Yes this could be documented better, but it is not tied to Blend Amount because that will change the color in the process. Someone may want to only change the alpha portion.

pjcozzi · 2016-12-05T22:24:16Z

Apps/Sandcastle/gallery/3D Models.html

-            maximumScale : 20000
+            maximumScale : 20000,
+            blendAmount : viewModel.blendAmount,
+            blendColor : Cesium.Color.fromHsl(viewModel.blendColor, 1.0, 0.5, viewModel.blendAlpha)


Do our users think of this as blending? Or just as applying a color to a model like Billboard.color?

What do you think of renaming this to color? I'm not sure what to rename blendAmount to...is there anywhere else in the Cesium API to mirror?

pjcozzi · 2016-12-05T22:25:15Z

Yes this could be documented better, but it is not tied to Blend Amount because that will change the color in the process. Someone may want to only change the alpha portion.

Couldn't they just set the color to white?

lilleyse · 2016-12-05T22:26:43Z

Couldn't they just set the color to white?

Not currently because the the model coloring is doing a mix, not a multiply.

pjcozzi · 2016-12-05T22:34:08Z

Couldn't they just set the color to white?
Not currently because the the model coloring is doing a mix, not a multiply.

I don't want to make this too complicated, but should we follow the same pattern as 3D Tiles features? Do you have use cases for mix? There will be lots of use cases for multiply, e.g., blue/red force.

lilleyse · 2016-12-05T22:38:55Z

I don't want to make this too complicated, but should we follow the same pattern as 3D Tiles features? Do you have use cases for mix? There will be lots of use cases for multiply, e.g., blue/red force.

Yeah I think supporting both modes may be a good idea, similar to Cesium3DTileColorBlendMode. Mix is nice for models that aren't close to white. Like a green model with a red blendColor will be black with multiply.

pjcozzi · 2016-12-05T22:53:33Z

Source/Scene/Model.js

+        return translucentCommand;
+    }
+
+    function updateBlendColor(model, frameState) {


Should we consider doing this as part of Cesium's derived commands? Or perhaps wait until #4314?

Yes both this and the 2D commands can be derived commands. I'll wait for #4314.

pjcozzi · 2016-12-05T22:54:33Z

Looks good, just those comments.

lilleyse · 2016-12-06T03:46:59Z

Ready now. I borrowed ColorBlendMode from 3d-tiles so HIGHLIGHT, REPLACE, and MIX are supported.

pjcozzi · 2016-12-06T15:00:20Z

Apps/Sandcastle/gallery/3D Models.html

@@ -19,10 +19,45 @@
 <body class="sandcastle-loading" data-sandcastle-bucket="bucket-requirejs.html">
 <style>
    @import url(../templates/bucket.css);
+    #toolbar {


@lilleyse up to you, but do you think that we've made this Sandcastle example too complicated? Would it be better (and more discoverable) to have separate 3D Models and 3D Model Coloring examples?

Plus silhouettes can be combined in that new demo.

pjcozzi · 2016-12-06T15:06:29Z

Is the separate Firefox issue, #4658, right?

pjcozzi · 2016-12-06T15:11:08Z

Source/DataSources/CzmlDataSource.js

@@ -34,6 +34,7 @@ define([
        '../Core/Spherical',
        '../Core/TimeInterval',
        '../Core/TimeIntervalCollection',
+        '../Scene/ColorBlendMode',


Can you update the CZML doc or submit an issue to update it?

pjcozzi · 2016-12-06T15:15:42Z

Source/Scene/Model.js

+        };
+    }
+
+    function createColorBlendFunction(model) {


Does 3D Tiles also use this? If so, should we make this a utility function on ColorBlendMode that takes a blendAmount?

pjcozzi · 2016-12-06T15:19:36Z

That's all my comments. This is a masterpiece.

lilleyse · 2016-12-06T15:41:54Z

Ready

lilleyse · 2016-12-06T16:47:23Z

Just have one small case to add when the alpha is 0.

lilleyse · 2016-12-06T16:51:58Z

Ready now.

Is the separate Firefox issue, #4658, right?

Yeah

lilleyse · 2016-12-06T16:52:39Z

CZML doc PR here: AnalyticalGraphicsInc/czml-writer#122

Added model color

d1d09f9

pjcozzi reviewed Oct 30, 2016

View reviewed changes

Merge branch 'master' into model-color

f8d2ac1

pjcozzi mentioned this pull request Nov 28, 2016

Support for model outlining #4314

Merged

6 tasks

lilleyse added 4 commits December 5, 2016 13:27

Updated 3D Models dev Sandcastle

5c7911d

Add to Entity API, CZML, and 3D Models showcase

bdc8425

Support alpha in blend color

4bd0ad6

Switch render states depending on alpha

250874e

lilleyse force-pushed the model-color branch from 5642434 to 250874e Compare December 5, 2016 21:41

Alpha test

dec5b0a

Remove separation of front/back commands

5c20c55

pjcozzi reviewed Dec 5, 2016

View reviewed changes

pjcozzi added 2 commits December 5, 2016 17:28

Merge remote-tracking branch 'origin/master' into model-color

5fcde36

Move CHANGES.md update to 1.29

dcf2f2b

pjcozzi reviewed Dec 5, 2016

View reviewed changes

lilleyse added 2 commits December 5, 2016 22:38

Small fix

77ace36

Use ColorBlendMode instead of always Mix

84fbd37

lilleyse force-pushed the model-color branch from c61cb1e to 84fbd37 Compare December 6, 2016 03:46

pjcozzi reviewed Dec 6, 2016

View reviewed changes

pjcozzi and others added 3 commits December 6, 2016 10:20

Update CHANGES.md

5e9e66d

Separate model coloring into its own demo

cade6fa

Use ColorBlendMode.getColorBlend function

6a60f25

lilleyse mentioned this pull request Dec 6, 2016

Added support for model color, colorBlendMode, and colorBlendAmount AnalyticalGraphicsInc/czml-writer#122

Merged

Don't issue command when alpha is 0

f23d436

lilleyse force-pushed the model-color branch from 165dd1b to f23d436 Compare December 6, 2016 16:51

pjcozzi merged commit 30113c0 into master Dec 6, 2016

pjcozzi deleted the model-color branch December 6, 2016 19:09

shunter mentioned this pull request Dec 6, 2016

Update CZML validation document and test. #4724

Merged

lilleyse mentioned this pull request Dec 8, 2016

Fix model alpha #4734

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Model coloring #4547

Model coloring #4547

lilleyse commented Oct 29, 2016

pjcozzi commented Oct 30, 2016

pjcozzi Oct 30, 2016

lilleyse Oct 31, 2016

pjcozzi Oct 30, 2016

pjcozzi commented Oct 30, 2016

lilleyse commented Dec 5, 2016

lilleyse commented Dec 5, 2016

lilleyse commented Dec 5, 2016

pjcozzi commented Dec 5, 2016

lilleyse commented Dec 5, 2016

pjcozzi commented Dec 5, 2016

pjcozzi commented Dec 5, 2016

pjcozzi commented Dec 5, 2016

lilleyse commented Dec 5, 2016

pjcozzi Dec 5, 2016

pjcozzi commented Dec 5, 2016

lilleyse commented Dec 5, 2016

pjcozzi commented Dec 5, 2016

lilleyse commented Dec 5, 2016

pjcozzi Dec 5, 2016

lilleyse Dec 6, 2016

pjcozzi commented Dec 5, 2016

lilleyse commented Dec 6, 2016

pjcozzi Dec 6, 2016

lilleyse Dec 6, 2016

pjcozzi commented Dec 6, 2016

pjcozzi Dec 6, 2016

lilleyse Dec 6, 2016

pjcozzi Dec 6, 2016

pjcozzi commented Dec 6, 2016

lilleyse commented Dec 6, 2016

lilleyse commented Dec 6, 2016

lilleyse commented Dec 6, 2016

lilleyse commented Dec 6, 2016

Model coloring #4547

Model coloring #4547

Conversation

lilleyse commented Oct 29, 2016

pjcozzi commented Oct 30, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pjcozzi commented Oct 30, 2016

lilleyse commented Dec 5, 2016

lilleyse commented Dec 5, 2016

lilleyse commented Dec 5, 2016

pjcozzi commented Dec 5, 2016

lilleyse commented Dec 5, 2016

pjcozzi commented Dec 5, 2016

pjcozzi commented Dec 5, 2016

pjcozzi commented Dec 5, 2016

lilleyse commented Dec 5, 2016

Choose a reason for hiding this comment

pjcozzi commented Dec 5, 2016

lilleyse commented Dec 5, 2016

pjcozzi commented Dec 5, 2016

lilleyse commented Dec 5, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pjcozzi commented Dec 5, 2016

lilleyse commented Dec 6, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pjcozzi commented Dec 6, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pjcozzi commented Dec 6, 2016

lilleyse commented Dec 6, 2016

lilleyse commented Dec 6, 2016

lilleyse commented Dec 6, 2016

lilleyse commented Dec 6, 2016