-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move WebGLConstants from Renderer to Core #4731
Conversation
global jsdoc page
… core-webglconstants
…um into core-webglconstants
@lasalvavida this is perfect, just one request: for maintenance and conciseness, it is perfectly OK to not document each individual enum vale in this case; instead, the reference doc for |
…o core-webglconstants
Okay. I need to see if I can make jsdoc hide the description column here for this. I added the comments because having a completely empty column looked a bit odd. |
… core-webglconstants
…nto core-webglconstants
This is updated removing the per entry comments and I've added links to the WebGL 1.0 and 2.0 specifications. I can't find a good way to hide the description column, so it is still there currently. Let me know if there are any other changes you would like to see, otherwise this is good to go. |
Thanks @lasalvavida! |
Justification:
Currently we use
WebGLConstants
in Core (ComponentDataType
,IndexDataType
,PixelFormat
,PrimitiveType
, ...), butWebGLConstants
lives in Renderer. MovingWebGLConstants
to Core makes Core completely self contained with no dependencies on the rest of Cesium.This PR also makes
WebGLConstants
public and updates the reference doc for it. We useWebGLConstants
as part of the Cesium API ingltf-pipeline
, so this seemed appropriate.There were also a few members missing
@memberof
declarations in other modules which were being added toglobal
in the doc, so this corrects those as well.