Use depth-stencil for FXAA #4747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I finally discovered why stencil operations (ground primitives and silhouettes) were not working on my machine. Normally the globe depth fbo is the principal fbo for the scene, but when the depth texture extension is not supported the FXAA fbo is used. I needed to change the FXAA depth texture/renderbuffer to use depth-stencil instead.
This also explains how we got away with not passing in
stencil : trueto the WebGL context. Even if the default FBO is not initialized that way you can still create FBOs with stencil buffers. So when I turned off depth textures and fxaa, so as to use the default FBO, the ground primitives were in fact broken. I just copied some of the code from #4314 into here to deal with that.