-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Orthographic projection in 3D and Columbus view #5021
Conversation
… enable frustum culling terrain.
…ng to bounding spheres.
…ographic projection.
…in pick. Fix flying to rectangle in columbus view.
New icons for perspective and orthographic views
CC @pmconne |
I dig the new widget.
|
Part of #4678 |
@pjcozzi @lilleyse This is ready for another review. @pjcozzi This is the change I mentioned offline: e13bc3d#diff-6298b280e4e0977bedd881b65b769863R993 If the camera is above a certain height then we zoom when rotating to avoid artifacts. |
Adjusting the terrain skirts also fixes #3710. |
There are still some situations where the camera can get stuck (it's possible I'm below the max height that is set). Like in this demo: http://localhost:8080/Apps/Sandcastle/index.html?src=CZML%20Colors.html&label=CZML usually I just rotate backwards completely, and then try to rotate forwards, but it end up getting stuck, though zooming still works. Otherwise, the new code changes and fixes look good.
Will this one be updated right before merging? |
@lilleyse This is ready for another look. When you get stuck, you can click space to rotate the view to look back at the ground just like if you get stuck looking up at terrain.
Yes, I updated it. To test, create a viewer with: |
Alright this is ready to go then. |
For some reason I'm not noticing any of the cracking issues linked in that issue in earlier versions of cesium, I'll check on my laptop tomorrow. |
I could only reproduce using the second link @hpinkos posted and going to |
Sandcastle examples for testing: http://cesium-dev.s3-website-us-east-1.amazonaws.com/cesium/ortho-3d/Apps/Sandcastle/index.html
This isn't ready for a code review. I want to have more people try this and report any problems when moving the camera around or if they have any suggestions for improvement.
There is a new widget to switch between orthographic and perspective projection. It is on by default, but will be disabled when this is ready to be merged.
After merge:
Fixes #2069.