Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orthographic projection in 3D and Columbus view #5021

Merged
merged 53 commits into from
Mar 15, 2017
Merged

Orthographic projection in 3D and Columbus view #5021

merged 53 commits into from
Mar 15, 2017

Conversation

bagnell
Copy link
Contributor

@bagnell bagnell commented Feb 22, 2017

Sandcastle examples for testing: http://cesium-dev.s3-website-us-east-1.amazonaws.com/cesium/ortho-3d/Apps/Sandcastle/index.html


This isn't ready for a code review. I want to have more people try this and report any problems when moving the camera around or if they have any suggestions for improvement.

There is a new widget to switch between orthographic and perspective projection. It is on by default, but will be disabled when this is ready to be merged.

  • Limit terrain/ imagery requests on the horizon.
  • Fix morphs
  • Add new tests
  • Update CHANGES.md
  • Fix ground primitives
  • Default new widget to hide

After merge:

  • Merge to 3d-tiles
  • Update 3d-tiles screen space error in for orthographic projections

Fixes #2069.

bagnell and others added 24 commits January 31, 2017 17:01
…in pick. Fix flying to rectangle in columbus view.
New icons for perspective and orthographic views
@pjcozzi
Copy link
Contributor

pjcozzi commented Feb 22, 2017

CC @pmconne

@pjcozzi
Copy link
Contributor

pjcozzi commented Feb 22, 2017

I dig the new widget.

  • When switching models, should the icons rotate? The scene mode widget does this to sync with the morph, but, for example, the imagery picker does not.
  • Should this widget be shown by default? I would think no since it won't be widely used and uses screen real estate.
  • Can we gray this out in 2D and also throw a reasonable exception when someone programmatically switches projection in 2D. Right now it is:

image

@pjcozzi
Copy link
Contributor

pjcozzi commented Feb 22, 2017

Part of #4678

@pjcozzi
Copy link
Contributor

pjcozzi commented Feb 22, 2017

Do you get these artifacts in the 3D models Sandcastle example?

image

@pjcozzi
Copy link
Contributor

pjcozzi commented Feb 22, 2017

  • Run the 3D models Sandcastle example
  • Switch to ortho
  • Hit the Home button, and get this exception:

image

@pjcozzi
Copy link
Contributor

pjcozzi commented Feb 22, 2017

Is this the correct behavior when zooming in ortho when just in front of the balloon model?

ok2

@bagnell
Copy link
Contributor Author

bagnell commented Mar 13, 2017

@pjcozzi @lilleyse This is ready for another review.

@pjcozzi This is the change I mentioned offline: e13bc3d#diff-6298b280e4e0977bedd881b65b769863R993 If the camera is above a certain height then we zoom when rotating to avoid artifacts.

@bagnell
Copy link
Contributor Author

bagnell commented Mar 14, 2017

Adjusting the terrain skirts also fixes #3710.

@pjcozzi
Copy link
Contributor

pjcozzi commented Mar 14, 2017

@lilleyse can you please do a final review and testing (and close and notify all the users in #3710)?

I would like to have this in master for a bit before we ship 1.32.

@pjcozzi pjcozzi mentioned this pull request Mar 14, 2017
53 tasks
@lilleyse
Copy link
Contributor

There are still some situations where the camera can get stuck (it's possible I'm below the max height that is set). Like in this demo: http://localhost:8080/Apps/Sandcastle/index.html?src=CZML%20Colors.html&label=CZML usually I just rotate backwards completely, and then try to rotate forwards, but it end up getting stuck, though zooming still works.

Otherwise, the new code changes and fixes look good.

Default new widget to hide

Will this one be updated right before merging?

@bagnell
Copy link
Contributor Author

bagnell commented Mar 15, 2017

@lilleyse This is ready for another look. When you get stuck, you can click space to rotate the view to look back at the ground just like if you get stuck looking up at terrain.

Default new widget to hide

Will this one be updated right before merging?

Yes, I updated it. To test, create a viewer with:
var viewer = new Cesium.Viewer('cesiumContainer', { projectionPicker : true });

@lilleyse
Copy link
Contributor

Alright this is ready to go then.

@lilleyse lilleyse merged commit ed034db into master Mar 15, 2017
@lilleyse lilleyse deleted the ortho-3d branch March 15, 2017 18:41
@lilleyse
Copy link
Contributor

Adjusting the terrain skirts also fixes #3710.

For some reason I'm not noticing any of the cracking issues linked in that issue in earlier versions of cesium, I'll check on my laptop tomorrow.

@bagnell
Copy link
Contributor Author

bagnell commented Mar 15, 2017

I could only reproduce using the second link @hpinkos posted and going to 110 45 with the geocoder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants