Add TopoJSON support to GeoJsonDataSource #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, here's a cool TopoJSON file you can use for trying this out: http://bl.ocks.org/mbostock/raw/4090846/us.json Note, it's slow because of the amount of data. Hopefully something we can fix soon with the batching branch. |
| @@ -16,7 +16,7 @@ Beta Releases | |||
| * Removed `CesiumViewerWidget` and replaced it with a new `Viewer` widget with mixin architecture. This new widget does not depend on Dojo and is part of the combined Cesium.js file. It is intended to be a flexible base widget for easily building robust applications. See [#838](https://github.com/AnalyticalGraphicsInc/cesium/pull/838) for the full details. | |||
| * Removed the Dojo-based `checkForChromeFrame` function, and replaced it with a new standalone version that returns a promise to signal when the asynchronous check has completed. | |||
| * Fix resizing issues in `CesiumWidget` ([#608](https://github.com/AnalyticalGraphicsInc/cesium/issues/608), [#834](https://github.com/AnalyticalGraphicsInc/cesium/issues/834)). | |||
| * Added initial support for [GeoJSON](http://www.geojson.org/) see [#890](https://github.com/AnalyticalGraphicsInc/cesium/pull/890) for details. | |||
| * Added initial support for [GeoJSON](http://www.geojson.org/) and [TopoJSON](https://github.com/mbostock/topojson) see [#890](https://github.com/AnalyticalGraphicsInc/cesium/pull/890) for details and [#906](https://github.com/AnalyticalGraphicsInc/cesium/pull/906) for details. | |||
There was a problem hiding this comment.
After removing the markdown link cruft this reads:
Added initial support for GeoJSON and TopoJSON see #890 for details and #906 for details.
Should be:
Added initial support for GeoJSON and TopoJSON. See #890 and #906 for details.
|
Looks good. Merging. |
shunter
added a commit
that referenced
this pull request
Jun 28, 2013
Add TopoJSON support to GeoJsonDataSource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TopoJSON is a popular geometry extension to GeoJSON with improved compression of vertex data. This change adds support to GeoJsonDataSource via the official TopoJSON JavaScript module.