-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for glTF 1.0.1 normalized to quantizeAttributes #165
Conversation
Used to generate the test model for CesiumGS/cesium#4247 @lilleyse, can you look at this when you get a chance? |
Yes I'll check this out soon. |
CC @lexaknyazev - glTF 1.0.1 |
I'm not following why this is needed. |
This is one of the advantages of having glTF 1.0.1. By adding the normalized flag to a quantized accessor, the decode matrix doesn't need to be stored as 1.0/65535.0, since this is done automatically by normalizing the data. This gives you the option to generate quantized models that decode with higher precision by not rounding in the glTF. The rounding is done by the GPU when it normalizes, so you automatically get the precision of the system you're running on. It also shrinks the glTF asset since the decode matrix won't be full of enormous floating point strings anymore. |
+1 from me |
OK, does this still strictly conform to the extension or does that need an update? |
No updates needed, this strictly conforms to the extension. |
Adds an optional flag to use the glTF 1.0.1 normalized property for higher precision decode matrices.