-
-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replace useEffect with useLayoutEffect for React 17 #305
Conversation
🦋 Changeset detectedLatest commit: 37eed99 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also move usage of the useWindowResizeListener
to this branch of the code?
react-textarea-autosize/src/index.tsx
Line 93 in 9ba98b9
if (typeof document !== 'undefined') { |
It will avoid React warnings about using useLayoutEffect
during SSR.
`useEffect` cleanup runs since React 17 asynchronously thats why it needs to be changed Fixes Andarist#259
@Andarist like that? |
Thanks! |
useEffect
cleanup runs since React 17 asynchronously thats why it needs to be changedWe deployed this change to a web application with quite a lot of users and could verify that the
Failed to execute 'getComputedStyle' on 'Window': parameter 1 is not of type 'Element'.
errors were gone.Fixes #259
cc @Andarist