Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require installing @typescript-eslint/parser #166

Closed
lishaduck opened this issue Jul 13, 2024 · 6 comments
Closed

Don't require installing @typescript-eslint/parser #166

lishaduck opened this issue Jul 13, 2024 · 6 comments

Comments

@lishaduck
Copy link
Contributor

For some reason, PNPM makes me install @typescript-eslint/parser as a peer dependency of Sheriff, rather than doing so automatically as a dependency. This should be investigated and fixed.

@AndreaPontrandolfo
Copy link
Owner

Depending on the version of PNPM, the auto-install-peers flag can be default true or default false.

@lishaduck
Copy link
Contributor Author

Depending on the version of PNPM, the auto-install-peers flag can be default true or default false.

It defaults to true, there's not a conflict. It's probably a bug in pnpm, but just making note of it in case there's a bug in packaging I need to cover in #161.

@lishaduck
Copy link
Contributor Author

I'm going to close this, we can see if it's still relevant with ESLint 9 + TSESLint 8

@lishaduck lishaduck closed this as not planned Won't fix, can't repro, duplicate, stale Aug 2, 2024
@lishaduck
Copy link
Contributor Author

For future reference, I think this was fixed in PNPM 9.7 (pnpm/pnpm#8323)

@AndreaPontrandolfo
Copy link
Owner

Indeed PNPM 9.5 was kind of a broken release.
I'll update to 9.7 in the next release, for sure.

@lishaduck
Copy link
Contributor Author

Indeed PNPM 9.5 was kind of a broken release. I'll update to 9.7 in the next release, for sure.

This was a bug installing it in my project, not installing the sheriff monorepo itself.
PNPM 9 is probably a worthwhile upgrade though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants