Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for NodaTime 2 #2

Closed
TheBeardedLlama opened this issue Jun 21, 2016 · 7 comments
Closed

Add support for NodaTime 2 #2

TheBeardedLlama opened this issue Jun 21, 2016 · 7 comments

Comments

@TheBeardedLlama
Copy link

Issue to track adding support for NodaTime 2

@BoasE
Copy link

BoasE commented Mar 28, 2017

same here. the support for NodaTime2 is essential as only NodaTime2 runs on .net core

@tetious
Copy link
Collaborator

tetious commented Mar 28, 2017

You can use NodaTime 1.4 with .net core, as with any project targeting PCL. In fact, we wrote this for a .net core project, and use it that way exclusively. :) We also have a .netstandard1.5 package out on nuget.

You'll need to import the PCL target, like this:

    "netstandard1.5": { 
      "imports": "portable-net40+sl5+win8+wp8+wpa81" 
    },

And you'll need to add Microsoft.NETCore.Portable.Compatibility. If you install MongoDb.Bson.NodaTime, this may happen automatically, though I'm not certain of that.

2.0 support will happen, but I've no idea when. PRs are welcome!

@TheBeardedLlama
Copy link
Author

TheBeardedLlama commented Mar 28, 2017

sorry, I've dropped the ball on this one big time!

I will see what I can do in the next couple of weeks

@johnknoop
Copy link
Contributor

Any progress on this? Let me know if you want a pull request.

@tetious
Copy link
Collaborator

tetious commented Jul 19, 2017

PRs are absolutely welcome! :)

@johnknoop
Copy link
Contributor

Created a PR just now

@tetious
Copy link
Collaborator

tetious commented Jul 19, 2017

Pushed to Nuget as v2.0.0. Many thanks @johnknoop!

@tetious tetious closed this as completed Jul 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants