-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update editor view #172
Draft
AnidemDex
wants to merge
25
commits into
main
Choose a base branch
from
update-editor-view
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Update editor view #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FancyDisplayer is a Displayer alternative, adding more details to command blocks, using Block and BlockCell nodes as visual representation of commands.
Add extra information at the end of the command for advanced scenarios. This will serve for template creation
This editor uses a fancy displayer, a new displayer that uses nodes to create the command list
Node based blocks that acts as a visual representation of a command
Add update function, that forces the recreation of its structuree
Made to ensure proper coloring in the future modifications
Deprecates background_color. Deprecates command_hint_icon. Deprecates command_text_color. Deprecates defines_default_branches Deprecates can_be_moved Deprecates can_be_selected Deprecates go_to_branch() Marks _add_variable as experimental. Marks _remove_variable as experimental. Marks _add_signal as experimental. Marks _remove_signal as experimental. Marks _add_function as experimental. Marks _remove_function as experimental.
Add "Command Data" group. Add "Block" group. Add block_name property. Add block_color property. Add block_custom_color property. Add block_icon property. Add debug properties for advanced debugging. Expose command_ properties as read-only properties.
Update block script to reflect changes in command properties
Add command_selected signal
Hide left section if no timeline is selected (future update)
Update its container flags
Update collection usage
Hopefully, nothing breaks
Make block change when command block_ properties are changed
Bugs so far:
|
This splits the views to have the runtime view sepparated from the editor view (little redundant but can't find a better selection of words
UndoRedo restored splitting runtime and editor behavior |
Remove editors, static variables seems bugged, preventing the script clean the static variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a kinda big update and I used this chance to adjust things for the future.
What's new?
Command
to include stuff related to the new fake tree. It should fix Standarize command block property definitions #164Collection
to expose more internal properties, just for debug purposes, using a EditorInspector.I think it also fix #161 and fix #107 (fix #92 for sure, fix #164)
Since now our command blocks are nodes and not objects (as was before with Tree), users can make their own blocks in custom scenes. I decided to not make the whole block replicate the old Tree look to force me to create a scene that mimics that old TreeItem look