New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secret key check allows for timing attacks #10

Open

TimDaub opened this issue Oct 25, 2021 · 0 comments · May be fixed by #11

TimDaub commented Oct 25, 2021 •

edited

Loading

timing attack
Line:

quadratic-voting/pages/api/events/details.js

Line 22 in f5bb541

event.secret_key && event.secret_key === secret_key ? true : false;

I recommend using: https://nodejs.org/api/crypto.html#cryptotimingsafeequala-b

TimDaub linked a pull request

that will close this issue

Fix timing attack vulnerability for admin secret #11

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment