Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: InfiniteScroll组件complete后reset,若筛选的新数据complete了且未铺满一屏,则status一直是… #567

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

count-back
Copy link
Contributor

@count-back count-back commented Aug 31, 2023

…loading

这个 PR 做了什么? (简要描述所做更改)
reset添加传参控制是否触发loadMore

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue id #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 满足以下需求:

  • 提交到 main 分支
  • Commit 信息遵循 Angular Style Commit Message Conventions
  • 代码遵循相关包中的 .eslintrc, .tslintrc, .stylelintrc 所规定的规范
  • 在本地测试可用,不会影响到其它功能

这个 PR 涉及以下平台:

  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 头条小程序
  • 快手小程序
  • QQ 轻应用
  • Web 平台(H5)

其它需要 Reviewer 或社区知晓的内容:

  • loadMore由监听进入视窗触发, reset不会触发,导致以下场景status会一直是loading
    • 筛选搜索时需要调用reset,status更改为loading, 搜索的新数据只有2条, 由于不触发loadMore,所以无法更新内部status
    • 筛选搜索的数据两次都为空数组,该场景容易复现bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants