Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster re-compute with new evaluation grid #85

Open
2 tasks
iyobill opened this issue Mar 23, 2023 · 6 comments
Open
2 tasks

Faster re-compute with new evaluation grid #85

iyobill opened this issue Mar 23, 2023 · 6 comments

Comments

@iyobill
Copy link

iyobill commented Mar 23, 2023

Thanks for this great tool! I was wondering, is there a simple way to run a new evaluation grid for an already-completed Mesh2HRTF calculation? I understand that an evaluation grid can have any number of points in it but if I do want to go back to a previously computed instance with a new set of evaluation grid points I'd like not to have to re-compute the boundary element variable data since that takes a lot of time to do. Thanks for your time and effort.

ToDo

  • Add functionality to add/remove EvaluationGrids from a project
  • Test new functionality
@f-brinkmann
Copy link
Contributor

Yes, this should be possible in theory. If I'm not mistaken, it would at least require an additional NumCalc command line parameter and either a manual or scripted edit of the project folder (add grids and update NC.inp files) or a corresponding option in the Blender export script mesh2input.py.

I can't estimate the effort for the first step, but the second step would probably take more time than I currently have.

@schaastrommla - what do you think?

@schaastrommla
Copy link
Contributor

I will have a closer look as soon as possible. In principle I see no problem, we just have to be careful not to overwrite already computed results. But it should be possible with one or two command line parameters.

@SDX-LV
Copy link
Contributor

SDX-LV commented Mar 27, 2023

Hi, just in case you are looking into updating NumCalc - one more improvement that would help a lot with Evaluation Grids is:

Ideally when NumCalc loads each evaluation grid, it should re-number the node IDs to use numbers from for example 10^6 and up. Then there are 10^6 nodes reserved for the 3D mesh and all the evaluation grids will always get valid IDs which would be the same for left and right ear simulations.

To avoid error with the same node IDs in multiple Evaluation grids.
Thanks!

@f-brinkmann
Copy link
Contributor

@SDX-LV this issue is handeled here: #86. Might be cleaner than automatically renumbering the nodes, which would mean that the IDs in the output folders are different than the IDs in the EvaluationGrid folder

@iyobill
Copy link
Author

iyobill commented Apr 24, 2023

Hi All,

Thanks for taking a look at this. Sounds like it is a definite possibility. Looking forward to hearing how it works out.

cheers,
Bill

@f-brinkmann
Copy link
Contributor

Update: A first version is now in https://github.com/Any2HRTF/Mesh2HRTF/tree/feature/run_numcalc_from_precomputed_boundary_data but requires manually manipulating the project folder. If anyone is interested in making the option available through the Python or Matlab API, I'm happy to discuss. I fear I won't find time for that soon. It would also be an option to only document the command line tool and merge release it as a feature...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants