Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .editorconfig file to define code style standards and apply to all existing files #351

Open
rossmills99 opened this issue Feb 25, 2022 · 2 comments
Assignees

Comments

@rossmills99
Copy link
Collaborator

Proposal:

Note: the last step requires using .NET 5.0 SDK for build, we'd need to make sure we can do that on the CI builds (maybe we already do, I haven't checked)

@DiscoPYF
Copy link
Collaborator

Regarding the third point, I think we could use dotnet-format to apply CI checks. The option --verify-no-changes allows "verifying" rather than "applying" the changes. We can run the command in an additional build step.

Example of possible commands:
dotnet tool install -g dotnet-format
dotnet-format arangodb-net-standard.sln

@rossmills99
Copy link
Collaborator Author

.NET 5 support for this exists though, so we might not need any additional tooling: https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/overview#enable-on-build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants