Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update /v2/items schema to support the numeric secondary_suffix_item_id #76

Closed
Archomeda opened this issue Nov 24, 2020 · 0 comments · Fixed by #77
Closed

Update /v2/items schema to support the numeric secondary_suffix_item_id #76

Archomeda opened this issue Nov 24, 2020 · 0 comments · Fixed by #77
Labels
Area: Web API v2 Related to the v2 web API Duration: Short Less than 2 hours of estimated work Priority: Medium Medium priority Resolution: Fixed The issue has been fixed Type: Refactor An improvement to the project that doesn't necessarily add a new features

Comments

@Archomeda
Copy link
Owner

Archomeda commented Nov 24, 2020 •
edited
Loading

The details.secondary_suffix_item_id property has traditionally always been a string, despite it being an integer.
With the latest schema change (2020-11-17T00:30:00.000Z), the custom string to int JSON converter can be phased out.

As a note, it also seems that version 5 of System.Text.Json also supports numeric values as strings, see dotnet/runtime#30255. So in case this pops up in a later stage, updating to version 5 is a better solution.

Reference: https://discordapp.com/channels/384735285197537290/384735523521953792/778065113948749834
@Archomeda Archomeda added Status: Ready Work is accepted and is planned for a future release Priority: Medium Medium priority Duration: Short Less than 2 hours of estimated work Area: Web API v2 Related to the v2 web API Type: Refactor An improvement to the project that doesn't necessarily add a new features labels Nov 24, 2020
@Archomeda Archomeda mentioned this issue Nov 24, 2020
Merged
@Archomeda Archomeda added Status: Waiting for release Work has finished and is waiting to be released and removed Status: Ready Work is accepted and is planned for a future release labels Nov 24, 2020
@Archomeda Archomeda added Resolution: Fixed The issue has been fixed and removed Status: Waiting for release Work has finished and is waiting to be released labels Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Web API v2 Related to the v2 web API Duration: Short Less than 2 hours of estimated work Priority: Medium Medium priority Resolution: Fixed The issue has been fixed Type: Refactor An improvement to the project that doesn't necessarily add a new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove string to int JSON converter Archomeda/Gw2Sharp
1 participant
@Archomeda