Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F-Droid can't build #1847

Closed
licaon-kter opened this issue Nov 28, 2023 · 38 comments · Fixed by #2209
Closed

F-Droid can't build #1847

licaon-kter opened this issue Nov 28, 2023 · 38 comments · Fixed by #2209

Comments

@licaon-kter
Copy link

licaon-kter commented Nov 28, 2023

@licaon-kter licaon-kter changed the title F-Droid can't build [Arcticons You] F-Droid can't build Nov 28, 2023
@TotallyAvailable
Copy link
Contributor

TotallyAvailable commented Nov 28, 2023

Given

< 	<item drawable="google_chrome" />
---
> 	<item drawable="goole_chrome" />

The 8.2.0 currently available is not the 8.2.0 that first got released.

ref
#1836 (comment)
#1836 (comment)

@licaon-kter
Copy link
Author

The 8.2.0 currently available is not the 8.2.0 that first got released.

The current one (Nov 25) was compared against and failed.

The "first" one was released when?

@licaon-kter
Copy link
Author

@Donnnno
Copy link
Collaborator

Donnnno commented Nov 29, 2023

Oh thanks for the notice! Looks like I updated the APK for the reproducible build, but the tag/release stayed the same.

@Donnnno
Copy link
Collaborator

Donnnno commented Dec 15, 2023

This will be fixed by simply releasing a new version, hoping to do that soon!

@licaon-kter
Copy link
Author

In theory yes :)

@linsui
Copy link

linsui commented Dec 24, 2023

Fixed.

@linsui
Copy link

linsui commented Dec 24, 2023

I guess I should also add the dayNight flavor?

@Donnnno
Copy link
Collaborator

Donnnno commented Dec 24, 2023

Fixed.

Fantastic!

@Donnnno
Copy link
Collaborator

Donnnno commented Dec 24, 2023

Fixed

Fantastic!

I guess I should also add the dayNight flavor?

We could! I haven't done it yet because I was thinking that we're polluting F-Droid with all these minimal variations at this point 😅 no idea if people actually will use it 🙃

@TotallyAvailable
Copy link
Contributor

Even with all Arcticons variants you still don't need your toes to count the number of available and updated Icon Packs available on F-Droid.

@linsui
Copy link

linsui commented Dec 24, 2023

We could! I haven't done it yet because I was thinking that we're polluting F-Droid with all these minimal variations at this point 😅 no idea if people actually will use it 🙃

I have packaged it. :)

@Donnnno
Copy link
Collaborator

Donnnno commented Dec 24, 2023

Omg amazing! Thank you so much @linsui

@Donnnno Donnnno closed this as completed Dec 24, 2023
@licaon-kter
Copy link
Author

licaon-kter commented Jan 29, 2024

@linsui
Copy link

linsui commented Jan 29, 2024

#1952

@Donnnno
Copy link
Collaborator

Donnnno commented Jan 29, 2024

Oh no :(

@Donnnno Donnnno reopened this Jan 29, 2024
@TotallyAvailable
Copy link
Contributor

TotallyAvailable commented Jan 30, 2024

Gone for a couple days and everything is falling appart apparently. Gonna eventually have a look to provide absolutely no helpful comment afterwards.

No but in all seriousness and in regards to #1952

  • Both PNG based versions made it through
  • Both XML based versions failed
  • No hot-fixes causing comparison mismatches

Might be a good idea to just summon @Kaiserdragon2

As it wasn't me who made the Day/Night version happen, a "no helpful comment" would be the best I could give.
"Something is broken and the code is there" doesn't necessarily equal a solution.

@Donnnno
Copy link
Collaborator

Donnnno commented Feb 4, 2024

Just pushed a new release, hopefully it should be fixed now :)

@licaon-kter
Copy link
Author

@Donnnno
Copy link
Collaborator

Donnnno commented Jul 23, 2024

oh no, again?!

@Donnnno Donnnno reopened this Jul 23, 2024
@Donnnno Donnnno changed the title [Arcticons You] F-Droid can't build F-Droid can't build Jul 23, 2024
@Donnnno
Copy link
Collaborator

Donnnno commented Jul 23, 2024

How can we check where it's different? So we can get an idea where it goes wrong?

@licaon-kter
Copy link
Author

licaon-kter commented Jul 23, 2024

You mean besides the list of files mentioned in the linked logs? I can build locally, which one do you want?

@Donnnno
Copy link
Collaborator

Donnnno commented Jul 23, 2024

A local build might help to compare the two.
There might be something in the build process that screws it up again? Maybe @Kaiserdragon2 knows what could cause it?

@licaon-kter
Copy link
Author

Here are the diff logs: art.tar.gz

or you want the APKs?

@Donnnno
Copy link
Collaborator

Donnnno commented Jul 23, 2024

Ah, I know what the differences are, thank you!

@Kaiserdragon2 the process of adding the contributor images, seems to differ with the android studio build, vs the f-droid build. Sounds like the sorting issue from a while ago.

When we've fixed this, I'll release a fix for F-Droid

@Donnnno
Copy link
Collaborator

Donnnno commented Jul 23, 2024

Update: I've published a new release https://github.com/Arcticons-Team/Arcticons/releases/tag/10.0.5-hotfix

@licaon-kter
Copy link
Author

licaon-kter commented Jul 24, 2024

diff -r /tmp/tmp3ajc543x/unsigned_binaries_com.donnnno.arcticons_1350.binary/content/META-INF/version-control-info.textproto /tmp/tmp3ajc543x/unsigned_com.donnnno.arcticons_1350/content/META-INF/version-control-info.textproto           4c4                                                        
<   revision: "ff344a25c087d9011c0e5066ec553fdbc3977586"   
---                                                       
 >   revision: "5b2d7f1be261964e596d6bb1ac31b3254179a3ae"  
Only in /tmp/tmp3ajc543x/unsigned_com.donnnno.arcticons_1350/content/assets/contributors: face_0.png                  Only in /tmp/tmp3ajc543x/unsigned_com.donnnno.arcticons_1350/content/assets/contributors: face_4.png                  Only in /tmp/tmp3ajc543x/unsigned_com.donnnno.arcticons_1350/content/assets/contributors: face_5.png                  
Only in /tmp/tmp3ajc543x/unsigned_com.donnnno.arcticons_1350/content/assets/contributors: face_6.png                  Only in /tmp/tmp3ajc543x/unsigned_com.donnnno.arcticons_1350/content/assets/contributors: face_7.png
Only in /tmp/tmp3ajc543x/unsigned_com.donnnno.arcticons_1350/content/assets/contributors: face_8.png
Only in /tmp/tmp3ajc543x/unsigned_com.donnnno.arcticons_1350/content/assets/contributors: face_9.png
Binary files /tmp/tmp3ajc543x/unsigned_binaries_com.donnnno.arcticons_1350.binary/content/res/IOs.xml and /tmp/tmp3ajc543x/unsigned_com.donnnno.arcticons_1350/content/res/IOs.xml differ

Nope :(

Of note, please build the APK from the tagged commit and upload that one to releases, instead of random APKs that you build locally to test before commiting changes.

/LE:L reformatted lof

@Donnnno
Copy link
Collaborator

Donnnno commented Jul 24, 2024

I always build them locally, so I don't get it...

@licaon-kter
Copy link
Author

I've reformatted the diff log above so it's clear:

<   revision: "ff344a25c087d9011c0e5066ec553fdbc3977586"   
---                                                       
>   revision: "5b2d7f1be261964e596d6bb1ac31b3254179a3ae"  

means that I built from the tagged 5b2d7f1 while you did it either from ff344a2 or from the tree BEFORE committing the changes in 5b2d7f1

@Donnnno
Copy link
Collaborator

Donnnno commented Jul 24, 2024

Oh, strange. Here we go again then. I've updated the APKs from the release. Hope you can trigger the run again?

image

@Donnnno
Copy link
Collaborator

Donnnno commented Jul 31, 2024

@licaon-kter can you check if it works? :)

@licaon-kter
Copy link
Author

==== detail begin ====
verification of APK with copied signature failed
Comparing reference APK to APK with copied signature...
Unexpected diff output:
Binary files /tmp/tmp14yvzfg5/unsigned_binaries_com.donnnno.arcticons_1350.binary/content/assets/contributors/downloaded/contributor_128.png and /tmp/tmp14yvzfg5/_tmp_tmp14yvzfg5_sigcp_com.donnnno.arcticons_1350/content/assets/contributors/downloaded/contributor_128.png differ
Binary files /tmp/tmp14yvzfg5/unsigned_binaries_com.donnnno.arcticons_1350.binary/content/res/IOs.xml and /tmp/tmp14yvzfg5/_tmp_tmp14yvzfg5_sigcp_com.donnnno.arcticons_1350/content/res/IOs.xml differ
==== detail end ====

from ff344a2

@Donnnno
Copy link
Collaborator

Donnnno commented Aug 5, 2024

10.4.0 should fix everything. We're doing automated building now :)

@licaon-kter
Copy link
Author

licaon-kter commented Aug 6, 2024

/LE: looks like there's no need for tricks 🎉

@licaon-kter
Copy link
Author

@Donnnno
Copy link
Collaborator

Donnnno commented Aug 6, 2024

Thank you!!
Pfew I started panicing a bit when I saw your previous message. Glad that you were able to solve it! ::)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants