Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F-Droid uses the Material You version for everything. #1878

Closed
Donnnno opened this issue Dec 26, 2023 · 6 comments · Fixed by #1879
Closed

F-Droid uses the Material You version for everything. #1878

Donnnno opened this issue Dec 26, 2023 · 6 comments · Fixed by #1879

Comments

@Donnnno
Copy link
Collaborator

Donnnno commented Dec 26, 2023

com.donnnno.arcticons.you:126 - web - metadata - log
com.donnnno.arcticons:126 - web - metadata - log
com.donnnno.arcticons.light:126 - web - metadata - log
com.donnnno.arcticons.daynight:126 - web - metadata - log

Interesting that Dark, Light and You are now named 'Material You' with the same Icon as well in the App (both F-Droid and Droid-ify)

Originally posted by @TotallyAvailable in #1799 (comment)

@Donnnno Donnnno changed the title >com.donnnno.arcticons.you:126 - [web](https://f-droid.org/packages/com.donnnno.arcticons.you/) - [metadata](https://gitlab.com/fdroid/fdroiddata/-/blob/0829a417e53c33a3fc797351dbcb4db618a3b4e8/metadata/com.donnnno.arcticons.you.yml) - [log](https://monitor.f-droid.org/builds/log/com.donnnno.arcticons.you/126#site-footer) F-Droid uses the Material You version for everything. Dec 26, 2023
@Donnnno
Copy link
Collaborator Author

Donnnno commented Dec 26, 2023

Screenshot_20231226_124124_F-Droid.jpg

🤔

@TotallyAvailable
Copy link
Contributor

It does appear to still list correct filesizes at least.

@petlyh
Copy link
Contributor

petlyh commented Dec 26, 2023

It looks like F-Droid depends on the flavor directories being named the same as the flavors. Therefore it, for example, looks for the black flavor metadata in app/src/black/play/, which doesn't exist since its metadata is in app/src/light/play/ instead. Because it doesn't exist, F-Droid reads metadata from all the flavor directories in order, making the last one (you) effective.

The flavor directories need to be renamed to match the flavor names post-Renamening. I can create a PR for it if you'd like.

Source for the F-Droid behavior:
https://gitlab.com/fdroid/fdroidserver/-/blob/master/fdroidserver/update.py#L806

@Donnnno
Copy link
Collaborator Author

Donnnno commented Dec 26, 2023

Oh thank you for figuring it out! If you're able to create a pr, that would be amazing!

@petlyh
Copy link
Contributor

petlyh commented Dec 26, 2023

If you're able to create a pr, that would be amazing!

Will do. Do you mind if I update the dashboard titles to reflect the new names as well while I'm at it? I assume it's not supposed to be like this:

@Donnnno
Copy link
Collaborator Author

Donnnno commented Dec 26, 2023

OOps, may have missed those! Thanks, go ahead :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants