Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor freezes on quit when plugin is enabled #114

Closed
francoisdlt opened this issue Jul 7, 2023 · 11 comments
Closed

Editor freezes on quit when plugin is enabled #114

francoisdlt opened this issue Jul 7, 2023 · 11 comments
Labels
Bug🐞 Something isn't working

Comments

@francoisdlt
Copy link

francoisdlt commented Jul 7, 2023

Describe the bug
When the plugin is enabled and I quit the editor, it freezes and stops responding

To Reproduce
Steps to reproduce the behavior:

  1. create new project
  2. add panku_console plugin
  3. enable panku_console plugin
  4. quit the editor

Expected behavior
the editor should quit normally

Desktop:

  • OS: macOS 13.4.1 on ARM M2 architecture
  • Editor : Godot 4.1 stable
  • plugin version : 1.5.162

Additional context
I still get the "Panku Console unloaded" message before it freezes
Whenever I disable the plugin, the problem disappears.

@Ark2000
Copy link
Owner

Ark2000 commented Jul 8, 2023

what about the latest commit?

@francoisdlt
Copy link
Author

still having the same problem :'(

@Ark2000
Copy link
Owner

Ark2000 commented Jul 10, 2023

sorry i dont have a mac machine, the only code piece i can think of is the _exit_tree function in plugin.gd since plugin.gd is the only editor script, you can comment out that function to see if it works.

also, try to run godot in verbose mode to get more detailed engine logs, i solved a lot of problems by reading that.

@francoisdlt
Copy link
Author

Following your suggestion, I found that commenting the print instruction solves the issue.

@Ark2000
Copy link
Owner

Ark2000 commented Jul 11, 2023

Following your suggestion, I found that commenting the print instruction solves the issue.

weird, but thankfully it works.

@Ark2000 Ark2000 closed this as completed Jul 11, 2023
@Ark2000 Ark2000 added the Bug🐞 Something isn't working label Jul 11, 2023
@Ark2000
Copy link
Owner

Ark2000 commented Jul 13, 2023

it is an engine bug introduced by 4.1, confirmed on windows os too, see godotengine/godot#79379

@Ark2000 Ark2000 reopened this Jul 13, 2023
@Ark2000
Copy link
Owner

Ark2000 commented Jul 20, 2023

_exit_tree() function was removed and now it should work well.

@Ark2000 Ark2000 closed this as completed Jul 20, 2023
@francoisdlt
Copy link
Author

thanks ! does the mirror repository update automatically ?

@Ark2000
Copy link
Owner

Ark2000 commented Jul 21, 2023

thanks ! does the mirror repository update automatically ?

unfortunately not, but I'll later work on this, and I have to manually update mirror repo until now.

@Ark2000
Copy link
Owner

Ark2000 commented Jul 21, 2023

#119

@francoisdlt
Copy link
Author

I confirm the freeze is gone with the new version and thanks for updating the mirror repo !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug🐞 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants