Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: use POSIX compliant techniques for cpio and rm #292

Closed
PaulCharlton opened this issue Jul 1, 2024 · 1 comment · May be fixed by #297
Closed

bug: use POSIX compliant techniques for cpio and rm #292

PaulCharlton opened this issue Jul 1, 2024 · 1 comment · May be fixed by #297

Comments

@PaulCharlton
Copy link

bug: use POSIX compliant techniques for cpio and rm

These changes are compatible with basic macOS implementations of cpio and rm

refs:
[use rm -rf to remove a directory]

asahi-installer/build.sh

Line 102 in 5f0814b

rm "$PACKAGE/asahi_firmware"

[use POSIX cpio which does not support --directory or -D]

asahi-installer/build.sh

Line 125 in 5f0814b

cpio -i -D "$PACKAGE/Frameworks/Python.framework"

PR forthcoming
@PaulCharlton PaulCharlton mentioned this issue Jul 1, 2024
Open
@marcan
Copy link
Member

marcan commented Jul 4, 2024

The build is intended to run from Linux, not macOS.

@marcan marcan closed this as completed Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bug: use POSIX compliant techniques for cpio and rm asahiLinux-musings/asahi-installer
2 participants
@marcan @PaulCharlton