Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move genesis config in runtime and organize variants with presets #1336

Closed
2 tasks
ipapandinas opened this issue Aug 23, 2024 · 2 comments · Fixed by #1341
Closed
2 tasks

Move genesis config in runtime and organize variants with presets #1336

ipapandinas opened this issue Aug 23, 2024 · 2 comments · Fixed by #1341
Labels
client This PR/Issue is related to the topic “client”. enhancement New feature or request runtime This PR/Issue is related to the topic “runtime”.

Comments

@ipapandinas
Copy link
Contributor

Description

Moving genesis config from the node into the runtime improve decoupling between the two.
This can be organized in a similar convention as changes introduces in paritytech/polkadot-sdk#2714:

Required Tasks

  • Create a genesis_config_presets.rs file per runtime that contains helpers for the GenesisBuilder API
  • Implement 3 presets: "live", "local_testnet" & "development"
@ipapandinas ipapandinas added enhancement New feature or request runtime This PR/Issue is related to the topic “runtime”. client This PR/Issue is related to the topic “client”. labels Aug 23, 2024
@Dinonard
Copy link
Member

@ipapandinas I just noticed this issue. Didn't know you've created it last week 😄

This is (mostly) resolved by this PR: #1341

However, I'm not sure what would be the difference between the listed types?

@ipapandinas ipapandinas mentioned this issue Aug 29, 2024
Merged
@ipapandinas ipapandinas linked a pull request Aug 29, 2024 that will close this issue
Runtime genesis generation #1341
Merged
@ipapandinas
Copy link
Contributor Author

After reviewing your PR, only the "development" preset coupled with tokyo testnet is relevant ✌️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
client This PR/Issue is related to the topic “client”. enhancement New feature or request runtime This PR/Issue is related to the topic “runtime”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Runtime genesis generation AstarNetwork/Astar
2 participants
@Dinonard @ipapandinas