Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where all mocks.py functions should go? #78

Open
bazkiaei opened this issue May 14, 2019 · 1 comment
Open

Where all mocks.py functions should go? #78

bazkiaei opened this issue May 14, 2019 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@bazkiaei
Copy link
Contributor

@bazkiaei I like this definition:

Looks to me like /utils is a place where you can place small snippets you can use throughout the application. Small functions to build bigger things with.

from erikras/react-redux-universal-hot-example#808

You designed parse_config to be used specifically for mocks.py, so I guess it makes sense.

This is scope creep on the PR, so let's close this PR without changing this, but create a new Issue to decide where all mocks.py functions should go -- other ones I think meet the definition I copied in above. Or better yet add it to the discussion about creating a Class for Mocks: #63

Originally posted by @lspitler in #69

@lspitler
Copy link
Member

Discuss after #71 and @wtgee and @AnthonyHorton about advise on how to structure

@lspitler lspitler added the help wanted Extra attention is needed label May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants