Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nvim-coverage): add keybindings #1186

Merged

Conversation

cristobalgvera
Copy link
Contributor

📑 Description

Add mappings to nvim-coverage.

Also, it was added the option to reload the coverage report if it changes, a useful option complemented with the ease to show the coverage added with the mappings.

ℹ Additional Information

The mapping was added as a second layer behind Tests map. This is because neotest and vim-test use the <Leader>T map and name it like that, allowing to complement the usage of those plugins without depending on it.

Copy link

github-actions bot commented Sep 2, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@Uzaaft Uzaaft changed the title feat(nvim-coverage): add mappings feat(nvim-coverage): add keybindings Sep 2, 2024
@Uzaaft
Copy link
Member

Uzaaft commented Sep 2, 2024

Ah now I see the other usage of test_prefix. My bad. 2s

@Uzaaft Uzaaft force-pushed the dev-add-nvim-coverage-mappings branch from e6f85cf to a825c26 Compare September 2, 2024 11:35
@cristobalgvera cristobalgvera force-pushed the dev-add-nvim-coverage-mappings branch 2 times, most recently from 3f53889 to be17dcd Compare September 2, 2024 12:31
@ALameLlama ALameLlama merged commit 07ff0d8 into AstroNvim:main Sep 3, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants