-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check mandatory ATMODAT requirements w.r.t. the description of Model’s Axes #114
Comments
Well should be covered by the CF-Checker as far as I know |
not necessarily. So, if you have timeseries netcdf files where each timestep is stored in a separate file, then users might omit adding a time dimension to the data variables. So maybe they just put var1(lat,lon) and not var1(time,lat,lon) which - according to the ATMODAT Standard - they should. The CF-Checker won't complain about var1(lat,lon) ... e.g. |
Well var1(lat,lon) is static in time, therefore there is no need to check anything. And if a timeseries is stored in separate files, I wouldn't call that timeseries which makes it static again. |
I don't agree with your "And if a timeseries is stored in separate files, I wouldn't call that timeseries which makes it static again.". If the nature of a variable is time-dependent (e.g. precipitation model output at a given time step), then it is not static...even if the output file only contains a single timestep. It is essential that users add time as a dimension because then, time information can be read in a machine-actionable manner because it is properly described via the time coordinate variable. And this allows users to merge the individual timesteps with e.g. Look at the header of a time series dataset where individual timesteps are saved in individual netcdf files... dimensions: static files are e.g. land-sea masks which are considered static (temporal changes over the model period are considered neglectable and the time dimension is therefore considered irrelevant). I think we need to discuss this issue with the AtMoDat team. ..... |
Sounds good to dicuss that later. |
The ATMODAT Standard v3.0 Section 4.3. Specifications for File Formats and Standards states
"The ATMODAT standard requires that:
[...]
• NetCDF file headers include description of time, coordinate and vertical axes according to Appendix E.
[...] "
How do we address this requirement?
I suggest that we add a note in the checker results that we are not checking for this requirement and that users should check this requirement themselves. What do you think?
The text was updated successfully, but these errors were encountered: