Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove api_retry, fix wrap_retry #233

Open
earonesty opened this issue Jan 31, 2020 · 0 comments
Open

Remove api_retry, fix wrap_retry #233

earonesty opened this issue Jan 31, 2020 · 0 comments

Comments

@earonesty
Copy link
Contributor

Integration tests can be flaky with providers requiring "retry", or disconnects, etc.

Tests now have 2 mechanisms for retrying... a "wrap_retry" around provider methods and an "api_retry".

The api function is not really guaranteed to be something we can catch (some use it as a with block for exception handling, others use it functionally, the mock just calls it to pass tests). It should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant