From 303ab36bc21e93dbf1b3d3354269b1ba39d1b4df Mon Sep 17 00:00:00 2001 From: JD Francis Date: Thu, 18 Jan 2024 11:45:36 -0600 Subject: [PATCH 1/3] Fix max width issue on select artists page --- packages/web/src/pages/sign-up-page/pages/SelectArtistsPage.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/web/src/pages/sign-up-page/pages/SelectArtistsPage.tsx b/packages/web/src/pages/sign-up-page/pages/SelectArtistsPage.tsx index 46431b6b6ce..232dbda2348 100644 --- a/packages/web/src/pages/sign-up-page/pages/SelectArtistsPage.tsx +++ b/packages/web/src/pages/sign-up-page/pages/SelectArtistsPage.tsx @@ -130,7 +130,6 @@ export const SelectArtistsPage = () => { mh={isMobile ? undefined : '5xl'} mb={isMobile ? undefined : 'xl'} style={styles} - css={!isMobile ? { maxWidth: '641px' } : undefined} > Date: Thu, 18 Jan 2024 11:50:56 -0600 Subject: [PATCH 2/3] Fix mobile CTA page --- packages/web/src/pages/sign-up-page/components/layout.tsx | 5 ++++- .../web/src/pages/sign-up-page/pages/MobileAppCtaPage.tsx | 4 ++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/packages/web/src/pages/sign-up-page/components/layout.tsx b/packages/web/src/pages/sign-up-page/components/layout.tsx index 63b8da62419..54e0f13d7eb 100644 --- a/packages/web/src/pages/sign-up-page/components/layout.tsx +++ b/packages/web/src/pages/sign-up-page/components/layout.tsx @@ -195,9 +195,12 @@ export const PageFooter = (props: PageFooterProps) => { const { isMobile } = useMedia() // On the MobileCTAPage we use this footer outside a formik context const { isSubmitting, dirty, isValid } = useFormikContext() ?? { - isSubmitting: false + isSubmitting: false, + dirty: true, + isValid: true } + return ( { }, [navigate]) return ( - + @@ -54,7 +54,7 @@ export const MobileAppCtaPage = () => { /> {messages.qrInstruction} - + ) } From 43b6e8edb3f7674f3254a3d901519fe580e5438a Mon Sep 17 00:00:00 2001 From: JD Francis Date: Thu, 18 Jan 2024 11:56:39 -0600 Subject: [PATCH 3/3] fix lint --- packages/web/src/pages/oauth-login-page/OAuthLoginPage.tsx | 4 ++-- packages/web/src/pages/sign-up-page/components/layout.tsx | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/web/src/pages/oauth-login-page/OAuthLoginPage.tsx b/packages/web/src/pages/oauth-login-page/OAuthLoginPage.tsx index ea4b5b9a081..dc967de6171 100644 --- a/packages/web/src/pages/oauth-login-page/OAuthLoginPage.tsx +++ b/packages/web/src/pages/oauth-login-page/OAuthLoginPage.tsx @@ -18,12 +18,12 @@ import { audiusBackendInstance } from 'services/audius-backend/audius-backend-in import { reportToSentry } from 'store/errors/reportToSentry' import { SIGN_UP_PAGE } from 'utils/route' -import { ContentWrapper } from './components/ContentWrapper' +import styles from './OAuthLoginPage.module.css' import { CTAButton } from './components/CTAButton' +import { ContentWrapper } from './components/ContentWrapper' import { PermissionsSection } from './components/PermissionsSection' import { useOAuthSetup } from './hooks' import { messages } from './messages' -import styles from './OAuthLoginPage.module.css' import { WriteOnceTx } from './utils' const { signOut } = signOutActions diff --git a/packages/web/src/pages/sign-up-page/components/layout.tsx b/packages/web/src/pages/sign-up-page/components/layout.tsx index 54e0f13d7eb..e7fa62e3c05 100644 --- a/packages/web/src/pages/sign-up-page/components/layout.tsx +++ b/packages/web/src/pages/sign-up-page/components/layout.tsx @@ -200,7 +200,6 @@ export const PageFooter = (props: PageFooterProps) => { isValid: true } - return (