Fix array checking in getQuerySelector()
#23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Property existance checking is insufficient for determining the type of a variable and actually led to a bug in this case: `<select>` elements have a `length` property denoting the number of contained `<option>` elements; `optimal-select` would treat this element as an array, causing it to fail.
|
Thanks for your help. Will also check for the next release if there are other cases which are not covered yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First off, massive kudos for your work on this library! I did find a rather sneaky bug outlined below.
Property existance checking is insufficient for determining the type of a variable and actually led to a bug in this case:
<select>elements have alengthproperty denoting the number of contained<option>elements;optimal-selectwould treat this element as an array, causing it to fail.