WIP: Specify user by ID in assign-user-to-coauthor #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobjS
reviewed
Aug 5, 2019
Floppy
commented
Aug 5, 2019
| @@ -210,30 +210,36 @@ public function assign_coauthors( $args, $assoc_args ) { | |||
| * @since 3.0 | |||
| * | |||
| * @subcommand assign-user-to-coauthor | |||
| * @synopsis --user_login=<user-login> --coauthor=<coauthor> | |||
| * @synopsis --user_login=<user-login> --user_id=<user-id> --coauthor=<coauthor> | |||
There was a problem hiding this comment.
I'm not at all sure how to specify that one of user_login or user_id is required. Anyone else?
There was a problem hiding this comment.
In git's man pages, parentheses and pipes are used to indicate that a subcommand accepts one and only one of a selection of flags (see the last line):
SYNOPSIS
git rebase [-i | --interactive] [<options>] [--exec <cmd>] [--onto <newbase>]
[<upstream> [<branch>]]
git rebase [-i | --interactive] [<options>] [--exec <cmd>] [--onto <newbase>]
--root [<branch>]
git rebase (--continue | --skip | --abort | --quit | --edit-todo | --show-current-patch)
So this line could be rewritten as:
* @synopsis ( --user_login=<user-login> | --user_id=<user-id> ) --coauthor=<coauthor>
RobjS
reviewed
Aug 5, 2019
Floppy
commented
Aug 5, 2019
RobjS
reviewed
Aug 5, 2019
|
Can you please refresh and fix the conflicts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user has already been deleted, we need to specify just the user ID when assigning coauthors, instead of the login. This PR adds a second command-line option. One of either
--user_idor--user_loginis required. Existing behaviour should be unchanged.