From 438e43cba1d0ca728e4b8bf0b93197155e38a189 Mon Sep 17 00:00:00 2001 From: jrfnl Date: Wed, 23 Aug 2023 00:01:43 +0200 Subject: [PATCH] Rulesets: move VariableAnalysis configuration from Go to Minimum While looking into 588, I noticed something which seemed odd, so I'm addressing this with this PR. The configuration which was added in 690 (and addressed 588) was added to the `WordPress-VIP-Go` ruleset, not the `WordPressVIPMinimum` ruleset from which the `WordPress-VIP-Go` ruleset inherits. I can not think of any pertinent reason why the configuration should be added for one, but not the other and I couldn't find any discussion on this either, so I propose moving the configuration from the `WordPress-VIP-Go` ruleset to the `WordPressVIPMinimum` ruleset. Ref: https://github.com/sirbrillig/phpcs-variable-analysis/releases/tag/v2.9.0 --- WordPress-VIP-Go/ruleset.xml | 8 -------- WordPressVIPMinimum/ruleset.xml | 7 +++++++ 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/WordPress-VIP-Go/ruleset.xml b/WordPress-VIP-Go/ruleset.xml index 58386a58..a3d77b22 100644 --- a/WordPress-VIP-Go/ruleset.xml +++ b/WordPress-VIP-Go/ruleset.xml @@ -244,14 +244,6 @@ 0 - - - - - - - - 0 diff --git a/WordPressVIPMinimum/ruleset.xml b/WordPressVIPMinimum/ruleset.xml index 2ce2511c..d723543d 100644 --- a/WordPressVIPMinimum/ruleset.xml +++ b/WordPressVIPMinimum/ruleset.xml @@ -145,6 +145,13 @@ + + + + + + +