Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics Type lowercases on save #1296

Merged
merged 1 commit into from
Aug 1, 2018
Merged

Conversation

AdelDima
Copy link
Contributor

@AdelDima AdelDima commented Jul 31, 2018

Fix #1133 to accept uppercase and lowercase string, dashes and underscores are allowed.

@westonruter westonruter added this to the v1.0 milestone Jul 31, 2018
@westonruter westonruter changed the title Analytics Type lowercases on save #1133 Analytics Type lowercases on save Aug 1, 2018
@westonruter westonruter merged commit 9cf5147 into ampproject:develop Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants