Prevent validation of auto-drafts, including when merely accessing New Post screen #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kienstra
approved these changes
Aug 1, 2018
There was a problem hiding this comment.
Approved
Hi @westonruter,
This looks good.
I also saw that $should_validate_post was true when creating a new post.
But with this PR, it is false, and it doesn't add validate_queued_posts_on_frontend() as a callback of shutdown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing #1297 I found that the frontend post validation logic is being invoked for
auto-draftposts. When accessing the New Post screen an auto-draft is created immediately, and this is resulting in that validation loopback request to the frontend to check the validity of a post that has nothing in it yet. Validation needs to be prevented for such posts; it should only be done once a post is saved as a draft.