Ensure only the post being edited in the classic editor is queued for validation #1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@westonruter it worked perfectly with WooCommerce CSV import and WordPress xml import. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a post is saved via the classic editor it needs to be re-validated on the frontend to show the validation warning:
However, at present the
save_postaction is being used in a way that other post edits are also causing re-validation to happen for them as well. This is particularly problematic when doing a mass import of posts.So what is needed is to restrict the
save_postaction to only follow-through when we are explicitly saving changes for a specific post in the classic editor.Note that this is all much cleaner for Gutenberg because we can rely on the REST API field to manage the re-validation.
Fixes #1404.