Support extracting dimensions for single URLs #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Back-compat for sites using the class directly and relying on it for extracting images for just a single URL.
mdbitz
approved these changes
Jan 22, 2018
|
There are some PHPCS errors that need to be corrected to get the build to pass: |
0.6 Release to master
…g-dimension-back-compat
## PHP_CodeSniffer Time: 1.08 secs; Memory: 16Mb tests/test-amp-image-dimension-extractor.php:39:12: error - Missing doc comment for function single_url__add_mock_dimension_callback() (Squiz.Commenting.FunctionComment.Missing) tests/test-amp-image-dimension-extractor.php:43:12: error - Missing doc comment for function single_url__mock_dimension_callback() (Squiz.Commenting.FunctionComment.Missing) tests/test-amp-image-dimension-extractor.php:52:12: error - Missing doc comment for function test__single_url() (Squiz.Commenting.FunctionComment.Missing) tests/test-amp-image-dimension-extractor.php:53:147: error - Inline comments must end in full-stops, exclamation marks, or question marks (Squiz.Commenting.InlineComment.InvalidEndChar) tests/test-amp-image-dimension-extractor.php:56:19: warning - Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space (Generic.Formatting.MultipleStatementAlignment.NotSameWarning)
tests/test-amp-image-dimension-extractor.php:47:8: error - Doc comment short description must start with a capital letter (Generic.Commenting.DocComment.ShortNotCapital)
|
Hi @westonruter Weston sorry this has sat, It's been on the back burner for quite a while. Let me or Mo know if any concerns. Thanks. |
westonruter
approved these changes
Aug 3, 2018
|
See also #1314 which undoes a bit of this PR: #1314 (review) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back-compat for sites using the class directly and relying on it for extracting images for just a single URL.
Fixes issues when doing something like:
AMP_Image_Dimension_Extractor::extract( $image_url )where$image_urlis a string and throwsInvalid argument supplied for foreach()warnings.