Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WP-CLI Script to create Comments #924

Merged
merged 7 commits into from
Feb 1, 2018
Merged

Add WP-CLI Script to create Comments #924

merged 7 commits into from
Feb 1, 2018

Conversation

DavidCramer
Copy link
Contributor

@DavidCramer DavidCramer commented Feb 1, 2018 •
edited by westonruter
Loading

Fixes #861

@ThierryA
Copy link
Collaborator

ThierryA commented Feb 1, 2018 •
edited
Loading

@DavidCramer I pushed two commits to reduce complexity a bit. I like your approach to get content using the Lorem API but it is maybe a bit over thinking, it shouldn’t be a blocker to run the script and a simple string with a bit of magic does the job.
Please take a look at my changes to double check them and this will be good to go.

@DavidCramer
Copy link
Contributor Author

@ThierryA I agree. I looked at the changes and its nice and simple. good work on that content generator. nice and simple. I may steal that..

@ThierryA ThierryA merged commit 5ac374f into develop Feb 1, 2018
@westonruter westonruter added this to the v0.7 milestone Feb 3, 2018
@westonruter westonruter deleted the add/861-cli-script-for-comments branch February 3, 2018 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThierryA ThierryA ThierryA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.
3 participants
@DavidCramer @ThierryA @westonruter