Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two Images Side by Side #16

Closed
iamtakashi opened this issue Mar 12, 2020 · 7 comments
Closed

Two Images Side by Side #16

iamtakashi opened this issue Mar 12, 2020 · 7 comments

Comments

@iamtakashi
Copy link
Contributor

iamtakashi commented Mar 12, 2020

images-1

<!-- wp:jetpack/layout-grid {"addGutterEnds":false,"column1DesktopSpan":6,"column1TabletSpan":4,"column1MobileSpan":4,"column2DesktopSpan":6,"column2TabletSpan":4,"column2MobileSpan":4,"className":"column1-desktop-grid__span-6 column1-desktop-grid__row-1 column2-desktop-grid__span-6 column2-desktop-grid__start-7 column2-desktop-grid__row-1 column1-tablet-grid__span-4 column1-tablet-grid__row-1 column2-tablet-grid__span-4 column2-tablet-grid__start-5 column2-tablet-grid__row-1 column1-mobile-grid__span-4 column1-mobile-grid__row-1 column2-mobile-grid__span-4 column2-mobile-grid__row-2"} -->
<div class="wp-block-jetpack-layout-grid alignfull column1-desktop-grid__span-6 column1-desktop-grid__row-1 column2-desktop-grid__span-6 column2-desktop-grid__start-7 column2-desktop-grid__row-1 column1-tablet-grid__span-4 column1-tablet-grid__row-1 column2-tablet-grid__span-4 column2-tablet-grid__start-5 column2-tablet-grid__row-1 column1-mobile-grid__span-4 column1-mobile-grid__row-1 column2-mobile-grid__span-4 column2-mobile-grid__row-2 wp-block-jetpack-layout-gutter__nowrap"><!-- wp:jetpack/layout-grid-column -->
<div class="wp-block-jetpack-layout-grid-column wp-block-jetpack-layout-grid__padding-none"><!-- wp:image {"id":9807,"sizeSlug":"full"} -->
<figure class="wp-block-image size-full"><img src="https://iamtakashi.files.wordpress.com/2020/03/patrick-langwallner-wifoabrx_wc-unsplash.jpg" alt="" class="wp-image-9807"/></figure>
<!-- /wp:image --></div>
<!-- /wp:jetpack/layout-grid-column -->

<!-- wp:jetpack/layout-grid-column -->
<div class="wp-block-jetpack-layout-grid-column wp-block-jetpack-layout-grid__padding-none"><!-- wp:image {"id":9810,"sizeSlug":"full"} -->
<figure class="wp-block-image size-full"><img src="https://iamtakashi.files.wordpress.com/2020/03/kristaps-ungurs-trgv9atxume-unsplash-3.jpg" alt="" class="wp-image-9810"/></figure>
<!-- /wp:image --></div>
<!-- /wp:jetpack/layout-grid-column --></div>
<!-- /wp:jetpack/layout-grid -->

A simple pattern with two images side-by-side. No issue.

@iamtakashi
Copy link
Contributor Author

We can ship this as there is no issue, and the grid block now has a gutter setting as well.

@iamtakashi iamtakashi changed the title Images side-by-side #1 Images side-by-side 1 Mar 12, 2020
@obenland
Copy link
Member

Where should those images be hosted?

@obenland
Copy link
Member

I just noticed Core already comes with that pattern: WordPress/gutenberg#20725

@iamtakashi
Copy link
Contributor Author

I just noticed Core already comes with that pattern

This pattern is still worth adding. The proportion is different, and the core version is based on a gallery and it lacks finer control such as gutter options that we have in this version with Layout Grid block.

Where should those images be hosted?

That's a good question. I was wondering about that too.

@obenland
Copy link
Member

I made some suggestions about images in Automattic/wp-calypso#40105. How do you feel about using Core's default images?

@iamtakashi
Copy link
Contributor Author

How do you feel about using Core's default images?

Core images are very limiting, and they don't allow us to express a variety of styles that we're aiming for.

@iamtakashi iamtakashi changed the title Images side-by-side 1 Two Images Side by Side 1 Mar 13, 2020
@iamtakashi iamtakashi changed the title Two Images Side by Side 1 Two Images Side by Side Mar 13, 2020
@alaczek
Copy link
Contributor

alaczek commented May 20, 2021

Closing the loop on that one, as it's already launched.

@alaczek alaczek closed this as completed May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants