Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colors package update would improve webpack compatibility #146

Open
Mr-Wallet opened this issue Aug 12, 2021 · 2 comments
Open

colors package update would improve webpack compatibility #146

Mr-Wallet opened this issue Aug 12, 2021 · 2 comments

Comments

@Mr-Wallet
Copy link

Mr-Wallet commented Aug 12, 2021

I'm trying to include this module in a project with webpack, which tries to gather up code into discrete bundles. It can't do this if it can't figure out where a require is likely to lead.

Older versions of colors included a setTheme method that took an arbitrary string and then tried to require that string directly, i.e. literally anything could possibly be required from literally anywhere... so webpack is in a bind. This was resolved several years ago in colors, and hopefully that dependency could be updated in the next release of cli-table.

I would have already opened a pull request myself today, but colors doesn't keep a changelog and I'm not sure how it's being used in this package, so I'm afraid of breaking something.

@schuerg
Copy link

schuerg commented Jan 10, 2022

Do not update colors npmjs package to >=1.4.1.

See https://security.snyk.io/vuln/SNYK-JS-COLORS-2331906

@DABH
Copy link

DABH commented Mar 24, 2022

This issue could be closed in favor of #167, which has effectively the same solution (#169) cc @chrean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants