From bec04eaef653fd91d032d7eb76617c284b7c3d63 Mon Sep 17 00:00:00 2001 From: kraftbj Date: Mon, 1 Nov 2021 21:25:54 +0000 Subject: [PATCH] Add webpack-config package (#21482) This is intended to (eventually) take care of several issues in the monorepo: * Calypso [doesn't use their own calyspo-build webpack config][1], which means it's not likely to be well-maintained. * It needs a hack to [work with monorepo packages][2]. * And another to [get correct image paths][3]. * And it [tries to redefine NODE_ENV, producing warnings][4]. * And we have to [override a weird default everywhere][5]. * We have to [name our JS files with ".min.js"][6] to avoid their being broken by a wpcom minifier, but WordPress.org's translation infrastructure [ignores such files][7]. * The plugin used to fix the above [had to be forked][8], adds 772K to the plugin, and results in spurious changes in TC builds. * The way translations are [being loaded for lazy-loaded bundles][9] is pretty hacky and doesn't lazy-load them. * We can't use any cache busting for the lazy-loaded bundles, because embedding hashes in the filename breaks the link to the translation file and putting it in a query parameter [breaks building the RTL css][10]. * Webpack's minification is [losing translator comments][11]. * Calypso-build has a lot of peer dependencies we don't actually need. Not everything we have uses sass or postcss, and we have our own infrastructure for jest, react, and so on. Currently we just ignore the 76 warnings from that. This is the first step towards fixing that: creating a private package that can hold the webpack and babel config fragments that we can share throughout the monorepo. Then we'll have a place to put the fixes for some of the other issues too. [1]: https://github.com/Automattic/jetpack/pull/21004#issuecomment-920344436 [2]: https://github.com/Automattic/wp-calypso/issues/53353 [3]: https://github.com/Automattic/wp-calypso/issues/56111 [4]: https://github.com/Automattic/wp-calypso/issues/56291 [5]: https://github.com/Automattic/jetpack/pull/21004 [6]: https://github.com/Automattic/jetpack/pull/20484 [7]: https://github.com/Automattic/jetpack/issues/21343 [8]: https://github.com/Automattic/jetpack/blob/7a5edd83/projects/plugins/jetpack/tools/webpack.helpers.js#L35 [9]: https://github.com/Automattic/jetpack/pull/20926 [10]: https://github.com/Automattic/jetpack/issues/21349 [11]: https://github.com/Automattic/jetpack/issues/16549 Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/1409697994 --- build/index.asset.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build/index.asset.php b/build/index.asset.php index 0e1432f..4b90a36 100644 --- a/build/index.asset.php +++ b/build/index.asset.php @@ -1 +1 @@ - array(), 'version' => 'b8be5a3732cd35215fd8e5d8c3641f2c'); \ No newline at end of file + array(), 'version' => 'e5fc698e0e69dbf62eeca91d066baa79'); \ No newline at end of file