-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shortcode: Slideshow: Make keyboard accessible #1001
Comments
Is everyone in favour of making the controls permanently visible, or is it worth a go at fading the controls in on focus as well as mouse over? |
@MichaelArestad and @lancewillett -- thoughts from a design/aesthetic perspective? |
I would make the controls always visible albeit somewhat transparent until hover. Like @kraftbj said, the current design makes it difficult and unintuitive for touchscreen users. |
So, maybe dim it to effective 50% opacity or the like? Unsure of the best way to actually apply a fix for ~. |
Sorry, but aren't we looking into this type of gallery? Quite possible I may be missing the point. |
@MichaelArestad and @georgestephanis , @chrisdc is correct. This ticket is specifically for the Slideshow (not Carousel), though I'm fine with making both better :-) |
There's a probably a better way of checking for focus, but replacing this with
|
Hi @chrisdc Also can you make the fade transitions 200ms instead of 400ms I find 400ms just a bit too slow. Thanks for your contributions let me know if you have any questions 👍 |
Hi @enejb I've added the code you asked for to the pull request. Let me know if you would like me to squash my changes at any point. |
The controls for the slideshow only appear on mouseover, making it difficult for keyboard users.
Initial look suggests this is what's requiring the mouse: https://github.com/Automattic/jetpack/blob/3.1.1/modules/shortcodes/js/slideshow-shortcode.js#L123-129
From user, ideal would be to remove the fade, always display, and ensure it can be reached via tab.
Reported in http://wordpress.org/support/topic/jetpack-and-web-accesibility?replies=1
The text was updated successfully, but these errors were encountered: